GH-369: As a smith I need to bump to Eclipse Oxygen

Jenkinsfile.new

@@ -13,10 +13,16 @@ pipeline {
         dockerfile {
             dir 'docker-build/'
             // Reuse repository.volume container if one exists, to speed up subsequent builds.
-            args '-v n4js-m2-repository:/usr/share/maven/ref/repository/'
+            args '-v n4js-m2-repository:/usr/share/maven/ref/repository/ -m 7500M'
             additionalBuildArgs '--build-arg MAVEN_CENTRAL_URL=' + env.MAVEN_CENTRAL_URL
         }
     }
+    environment {
+        MAVEN_OPTS = "-XX:+UnlockExperimentalVMOptions " +
+                     "-XX:+UseCGroupMemoryLimitForHeap " +
+                     "-XX:MaxRAMFraction=2 "             +
+                     "-XshowSettings:vm "
+    }
     options {
         ansiColor('xterm')
         buildDiscarder(

README.adoc

@@ -37,7 +37,7 @@ This installer is to be downloaded from https://wiki.eclipse.org/Eclipse_Install
 Run the installer and apply the following steps:
 
 1. change to "Advance Mode" via the menu (upper-right corner) (no need to move the installer)
-2. select a product, e.g. "Eclipse IDE for Eclipse Committers" with product version "Latest(Neon)"
+2. select a product, e.g. "Eclipse IDE for Eclipse Committers" with product version "Oxygen"
 3. double-click the entry **Eclipse Projects/N4JS** so that it is shown in the catalog view below
 4. on the next page, configure paths accordingly. You only have to configure the installation and workspace folder.
 5. start installation
@@ -48,7 +48,7 @@ The installer will then guide you through the rest of the installation. All plug
 
 For a manual install, clone the code and import all top-level projects from the docs, features, plugins, releng, testhelpers, and tests folders. Activate the targetplatform contained in the `releng/org.eclipse.n4js.targetplatform/` project.
 
-The N4JS IDE is developed with Eclipse Neon 4.6 or better since the system is based on Eclipse anyway.
+The N4JS IDE is developed with Eclipse Oxygen 4.7 or better since the system is based on Eclipse anyway.
 It is almost impossible to use another IDE to develop Eclipse plugins. The list of required plugins includes:
 
 - Xtext/Xtend 2.10.0

docker-build/Dockerfile

@@ -62,7 +62,6 @@ RUN set -ex && \
         56730D5401028683275BD23C23EFEFE93C4CFFFE \
         77984A986EBC2AA786BC0F66B01FBB92821C587A ; \
     do \
-        gpg --keyserver hkp://pgp.mit.edu:80                --recv-keys "$key" || \
         gpg --keyserver hkp://keyserver.pgp.com:80          --recv-keys "$key" || \
         gpg --keyserver hkp://ha.pool.sks-keyservers.net:80 --recv-keys "$key" ; \
   done

plugins/org.eclipse.n4js.external.libraries/src/org/eclipse/n4js/external/libraries/ShippedCodeAccess.java

@@ -16,6 +16,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
+import java.io.OutputStream;
 import java.net.JarURLConnection;
 import java.net.URL;
 import java.net.URLConnection;
@@ -31,6 +32,9 @@
 import org.eclipse.n4js.utils.io.FileDeleter;
 
 import com.google.common.base.StandardSystemProperty;
+import com.google.common.io.ByteSink;
+import com.google.common.io.ByteStreams;
+import com.google.common.io.Files;
 
 /**
  * Provides access to the shipped code for setups that don't work with proper workspace, e.g. unit tests for the
@@ -114,8 +118,11 @@ protected static String recursivelyCopyContent(JarURLConnection connection, Stri
 					}
 				} else {
 					checkState(newResource.createNewFile(), "Error while creating new file at: " + newResource);
-					try (final InputStream is = jarFile.getInputStream(entry)) {
-						com.google.common.io.Files.copy(() -> is, newResource);
+					ByteSink byteSink = Files.asByteSink(newResource);
+					try (
+							final InputStream is = jarFile.getInputStream(entry);
+							OutputStream outputStream = byteSink.openStream();) {
+						ByteStreams.copy(is, outputStream);
 					}
 				}
 				newResource.deleteOnExit();

plugins/org.eclipse.n4js.flowgraphs/src/org/eclipse/n4js/flowgraphs/analysers/DivisionByZeroAnalyser.java

@@ -57,7 +57,7 @@ static private boolean isZeroLiteral(Expression expr) {
 		if (expr instanceof NumericLiteral) {
 			NumericLiteral numLit = (NumericLiteral) expr;
 			BigDecimal litValue = numLit.getValue();
-			return litValue.equals(0);
+			return litValue.equals(new BigDecimal(0));
 		}
 		return false;
 	}

plugins/org.eclipse.n4js.flowgraphs/src/org/eclipse/n4js/flowgraphs/dataflow/symbols/SymbolFactory.java

@@ -10,6 +10,7 @@
  */
 package org.eclipse.n4js.flowgraphs.dataflow.symbols;
 
+import java.math.BigDecimal;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -102,7 +103,7 @@ static private Symbol createFromSuperLiteral(ControlFlowElement cfe) {
 	}
 
 	static private Symbol createFromNumericLiteral(ControlFlowElement cfe) {
-		if (new Integer(0).equals(((NumericLiteral) cfe).getValue())) {
+		if (new BigDecimal(0).equals(((NumericLiteral) cfe).getValue())) {
 			return new SymbolOfZeroLiteral((NumericLiteral) cfe);
 		}
 		return null;

plugins/org.eclipse.n4js.flowgraphs/src/org/eclipse/n4js/flowgraphs/dataflow/symbols/SymbolOfZeroLiteral.java

@@ -10,6 +10,8 @@
  */
 package org.eclipse.n4js.flowgraphs.dataflow.symbols;
 
+import java.math.BigDecimal;
+
 import org.eclipse.n4js.n4JS.NumericLiteral;
 
 /**
@@ -34,7 +36,7 @@ public String getName() {
 
 	@Override
 	public boolean isZeroLiteral() {
-		return nl.getValue().equals(0);
+		return nl.getValue().equals(new BigDecimal(0));
 	}
 
 }

plugins/org.eclipse.n4js.jsdoc/emf-gen/org/eclipse/n4js/jsdoc/dom/Doclet.java

@@ -51,7 +51,7 @@ public interface Doclet extends Composite {
 	 * <!-- begin-user-doc -->
 	 * <!-- end-user-doc -->
 	 * @model unique="false" titleUnique="false"
-	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='final <%org.eclipse.xtext.xbase.lib.Functions.Function1%><<%org.eclipse.n4js.jsdoc.dom.LineTag%>, <%java.lang.Boolean%>> _function = new <%org.eclipse.xtext.xbase.lib.Functions.Function1%><<%org.eclipse.n4js.jsdoc.dom.LineTag%>, <%java.lang.Boolean%>>()\n{\n\tpublic <%java.lang.Boolean%> apply(final <%org.eclipse.n4js.jsdoc.dom.LineTag%> it)\n\t{\n\t\t<%java.lang.String%> _title = it.getTitle().getTitle();\n\t\treturn <%java.lang.Boolean%>.valueOf(<%com.google.common.base.Objects%>.equal(_title, title));\n\t}\n};\n<%org.eclipse.n4js.jsdoc.dom.LineTag%> _findFirst = <%org.eclipse.xtext.xbase.lib.IterableExtensions%>.<<%org.eclipse.n4js.jsdoc.dom.LineTag%>>findFirst(this.getLineTags(), _function);\nreturn (_findFirst != null);'"
+	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='final &lt;%org.eclipse.xtext.xbase.lib.Functions.Function1%&gt;&lt;&lt;%org.eclipse.n4js.jsdoc.dom.LineTag%&gt;, &lt;%java.lang.Boolean%&gt;&gt; _function = new &lt;%org.eclipse.xtext.xbase.lib.Functions.Function1%&gt;&lt;&lt;%org.eclipse.n4js.jsdoc.dom.LineTag%&gt;, &lt;%java.lang.Boolean%&gt;&gt;()\n{\n\tpublic &lt;%java.lang.Boolean%&gt; apply(final &lt;%org.eclipse.n4js.jsdoc.dom.LineTag%&gt; it)\n\t{\n\t\t&lt;%java.lang.String%&gt; _title = it.getTitle().getTitle();\n\t\treturn &lt;%java.lang.Boolean%&gt;.valueOf(&lt;%com.google.common.base.Objects%&gt;.equal(_title, title));\n\t}\n};\n&lt;%org.eclipse.n4js.jsdoc.dom.LineTag%&gt; _findFirst = &lt;%org.eclipse.xtext.xbase.lib.IterableExtensions%&gt;.&lt;&lt;%org.eclipse.n4js.jsdoc.dom.LineTag%&gt;&gt;findFirst(this.getLineTags(), _function);\nreturn (_findFirst != null);'"
 	 * @generated
 	 */
 	boolean hasLineTag(String title);
@@ -60,7 +60,7 @@ public interface Doclet extends Composite {
 	 * <!-- begin-user-doc -->
 	 * <!-- end-user-doc -->
 	 * @model unique="false" titleUnique="false"
-	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='final <%org.eclipse.xtext.xbase.lib.Functions.Function1%><<%org.eclipse.n4js.jsdoc.dom.LineTag%>, <%java.lang.Boolean%>> _function = new <%org.eclipse.xtext.xbase.lib.Functions.Function1%><<%org.eclipse.n4js.jsdoc.dom.LineTag%>, <%java.lang.Boolean%>>()\n{\n\tpublic <%java.lang.Boolean%> apply(final <%org.eclipse.n4js.jsdoc.dom.LineTag%> it)\n\t{\n\t\t<%java.lang.String%> _title = it.getTitle().getTitle();\n\t\treturn <%java.lang.Boolean%>.valueOf(<%com.google.common.base.Objects%>.equal(_title, title));\n\t}\n};\nreturn <%org.eclipse.emf.common.util.ECollections%>.<<%org.eclipse.n4js.jsdoc.dom.LineTag%>>toEList(<%org.eclipse.xtext.xbase.lib.IterableExtensions%>.<<%org.eclipse.n4js.jsdoc.dom.LineTag%>>filter(this.getLineTags(), _function));'"
+	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='final &lt;%org.eclipse.xtext.xbase.lib.Functions.Function1%&gt;&lt;&lt;%org.eclipse.n4js.jsdoc.dom.LineTag%&gt;, &lt;%java.lang.Boolean%&gt;&gt; _function = new &lt;%org.eclipse.xtext.xbase.lib.Functions.Function1%&gt;&lt;&lt;%org.eclipse.n4js.jsdoc.dom.LineTag%&gt;, &lt;%java.lang.Boolean%&gt;&gt;()\n{\n\tpublic &lt;%java.lang.Boolean%&gt; apply(final &lt;%org.eclipse.n4js.jsdoc.dom.LineTag%&gt; it)\n\t{\n\t\t&lt;%java.lang.String%&gt; _title = it.getTitle().getTitle();\n\t\treturn &lt;%java.lang.Boolean%&gt;.valueOf(&lt;%com.google.common.base.Objects%&gt;.equal(_title, title));\n\t}\n};\nreturn &lt;%org.eclipse.emf.common.util.ECollections%&gt;.&lt;&lt;%org.eclipse.n4js.jsdoc.dom.LineTag%&gt;&gt;toEList(&lt;%org.eclipse.xtext.xbase.lib.IterableExtensions%&gt;.&lt;&lt;%org.eclipse.n4js.jsdoc.dom.LineTag%&gt;&gt;filter(this.getLineTags(), _function));'"
 	 * @generated
 	 */
 	EList<LineTag> lineTags(String title);

plugins/org.eclipse.n4js.jsdoc/emf-gen/org/eclipse/n4js/jsdoc/dom/DocletElement.java

@@ -95,7 +95,7 @@ public interface DocletElement extends EObject {
 	 * <!-- begin-user-doc -->
 	 * <!-- end-user-doc -->
 	 * @model unique="false" offsetUnique="false"
-	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='return ((this.getBegin() <= offset) && (this.getEnd() > offset));'"
+	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='return ((this.getBegin() &lt;= offset) &amp;&amp; (this.getEnd() &gt; offset));'"
 	 * @generated
 	 */
 	boolean covers(int offset);

plugins/org.eclipse.n4js.jsdoc/emf-gen/org/eclipse/n4js/jsdoc/dom/FullMemberReference.java

@@ -90,7 +90,7 @@ public interface FullMemberReference extends FullTypeReference {
 	 * <!-- begin-user-doc -->
 	 * <!-- end-user-doc -->
 	 * @model unique="false"
-	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='return ((this.getMemberName() != null) && (!this.getMemberName().isEmpty()));'"
+	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='return ((this.getMemberName() != null) &amp;&amp; (!this.getMemberName().isEmpty()));'"
 	 * @generated
 	 */
 	boolean memberNameSet();
@@ -99,7 +99,7 @@ public interface FullMemberReference extends FullTypeReference {
 	 * <!-- begin-user-doc -->
 	 * <!-- end-user-doc -->
 	 * @model unique="false"
-	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='<%java.lang.String%> _string = super.toString();\n<%java.lang.StringBuilder%> strb = new <%java.lang.StringBuilder%>(_string);\nboolean _memberNameSet = this.memberNameSet();\nif (_memberNameSet)\n{\n\tint _length = strb.length();\n\tboolean _greaterThan = (_length > 0);\n\tif (_greaterThan)\n\t{\n\t\tboolean _isStaticMember = this.isStaticMember();\n\t\tif (_isStaticMember)\n\t\t{\n\t\t\tstrb.append(\"#\");\n\t\t}\n\t\telse\n\t\t{\n\t\t\tstrb.append(\".\");\n\t\t}\n\t}\n\tstrb.append(this.getMemberName());\n}\nreturn strb.toString();'"
+	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='&lt;%java.lang.String%&gt; _string = super.toString();\n&lt;%java.lang.StringBuilder%&gt; strb = new &lt;%java.lang.StringBuilder%&gt;(_string);\nboolean _memberNameSet = this.memberNameSet();\nif (_memberNameSet)\n{\n\tint _length = strb.length();\n\tboolean _greaterThan = (_length &gt; 0);\n\tif (_greaterThan)\n\t{\n\t\tboolean _isStaticMember = this.isStaticMember();\n\t\tif (_isStaticMember)\n\t\t{\n\t\t\tstrb.append(\"#\");\n\t\t}\n\t\telse\n\t\t{\n\t\t\tstrb.append(\".\");\n\t\t}\n\t}\n\tstrb.append(this.getMemberName());\n}\nreturn strb.toString();'"
 	 * @generated
 	 */
 	String toString();

plugins/org.eclipse.n4js.jsdoc/emf-gen/org/eclipse/n4js/jsdoc/dom/FullTypeReference.java

@@ -58,7 +58,7 @@ public interface FullTypeReference extends SimpleTypeReference {
 	 * <!-- begin-user-doc -->
 	 * <!-- end-user-doc -->
 	 * @model unique="false"
-	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='return ((this.getModuleName() != null) && (!this.getModuleName().isEmpty()));'"
+	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='return ((this.getModuleName() != null) &amp;&amp; (!this.getModuleName().isEmpty()));'"
 	 * @generated
 	 */
 	boolean moduleNameSet();
@@ -67,7 +67,7 @@ public interface FullTypeReference extends SimpleTypeReference {
 	 * <!-- begin-user-doc -->
 	 * <!-- end-user-doc -->
 	 * @model unique="false"
-	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='<%java.lang.StringBuilder%> strb = new <%java.lang.StringBuilder%>();\nboolean _moduleNameSet = this.moduleNameSet();\nif (_moduleNameSet)\n{\n\tstrb.append(this.getModuleName());\n}\nboolean _typeNameSet = this.typeNameSet();\nif (_typeNameSet)\n{\n\tint _length = strb.length();\n\tboolean _greaterThan = (_length > 0);\n\tif (_greaterThan)\n\t{\n\t\tstrb.append(\".\");\n\t}\n\tstrb.append(this.getTypeName());\n}\nreturn strb.toString();'"
+	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='&lt;%java.lang.StringBuilder%&gt; strb = new &lt;%java.lang.StringBuilder%&gt;();\nboolean _moduleNameSet = this.moduleNameSet();\nif (_moduleNameSet)\n{\n\tstrb.append(this.getModuleName());\n}\nboolean _typeNameSet = this.typeNameSet();\nif (_typeNameSet)\n{\n\tint _length = strb.length();\n\tboolean _greaterThan = (_length &gt; 0);\n\tif (_greaterThan)\n\t{\n\t\tstrb.append(\".\");\n\t}\n\tstrb.append(this.getTypeName());\n}\nreturn strb.toString();'"
 	 * @generated
 	 */
 	String toString();
@@ -76,7 +76,7 @@ public interface FullTypeReference extends SimpleTypeReference {
 	 * <!-- begin-user-doc -->
 	 * <!-- end-user-doc -->
 	 * @model unique="false"
-	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='<%java.lang.StringBuilder%> strb = new <%java.lang.StringBuilder%>();\nboolean _moduleNameSet = this.moduleNameSet();\nif (_moduleNameSet)\n{\n\tstrb.append(this.getModuleName());\n}\nboolean _typeNameSet = this.typeNameSet();\nif (_typeNameSet)\n{\n\tstrb.append(\".\");\n\tstrb.append(this.getTypeName());\n}\nreturn strb.toString();'"
+	 *        annotation="http://www.eclipse.org/emf/2002/GenModel body='&lt;%java.lang.StringBuilder%&gt; strb = new &lt;%java.lang.StringBuilder%&gt;();\nboolean _moduleNameSet = this.moduleNameSet();\nif (_moduleNameSet)\n{\n\tstrb.append(this.getModuleName());\n}\nboolean _typeNameSet = this.typeNameSet();\nif (_typeNameSet)\n{\n\tstrb.append(\".\");\n\tstrb.append(this.getTypeName());\n}\nreturn strb.toString();'"
 	 * @generated
 	 */
 	String fullTypeName();