Skip to content

Commit

Permalink
Skip iselect + bcmp* and scmp* tests on Z
Browse files Browse the repository at this point in the history
The Z codegen currently has a known bug with sub-integer compares as the
first child of an integral select opcode. The tests for this have been
temporarily disabled until this can be resolved.

Signed-off-by: Ben Thomas <ben@benthomas.ca>
  • Loading branch information
aviansie-ben committed Sep 2, 2020
1 parent 58d2d97 commit 0987b88
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions fvtest/compilertriltest/SelectTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1352,6 +1352,8 @@ class Int32SelectInt8CompareTest : public SelectCompareTest<int8_t, int32_t> {};

TEST_P(Int32SelectInt8CompareTest, UsingLoadParam) {
SKIP_ON_ARM(MissingImplementation);
SKIP_ON_S390(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_S390X(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";

auto param = to_struct(GetParam());

Expand Down Expand Up @@ -1382,6 +1384,8 @@ TEST_P(Int32SelectInt8CompareTest, UsingLoadParam) {

TEST_P(Int32SelectInt8CompareTest, UsingConstCompare) {
SKIP_ON_ARM(MissingImplementation);
SKIP_ON_S390(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_S390X(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";

auto param = to_struct(GetParam());

Expand Down Expand Up @@ -1413,6 +1417,8 @@ TEST_P(Int32SelectInt8CompareTest, UsingConstCompare) {

TEST_P(Int32SelectInt8CompareTest, UsingConstValues) {
SKIP_ON_ARM(MissingImplementation);
SKIP_ON_S390(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_S390X(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";

auto param = to_struct(GetParam());

Expand Down Expand Up @@ -1453,6 +1459,8 @@ class Int32SelectInt16CompareTest : public SelectCompareTest<int16_t, int32_t> {

TEST_P(Int32SelectInt16CompareTest, UsingLoadParam) {
SKIP_ON_ARM(MissingImplementation);
SKIP_ON_S390(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_S390X(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";

auto param = to_struct(GetParam());

Expand Down Expand Up @@ -1483,6 +1491,8 @@ TEST_P(Int32SelectInt16CompareTest, UsingLoadParam) {

TEST_P(Int32SelectInt16CompareTest, UsingConstCompare) {
SKIP_ON_ARM(MissingImplementation);
SKIP_ON_S390(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_S390X(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";

auto param = to_struct(GetParam());

Expand Down Expand Up @@ -1514,6 +1524,8 @@ TEST_P(Int32SelectInt16CompareTest, UsingConstCompare) {

TEST_P(Int32SelectInt16CompareTest, UsingConstValues) {
SKIP_ON_ARM(MissingImplementation);
SKIP_ON_S390(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_S390X(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";

auto param = to_struct(GetParam());

Expand Down

0 comments on commit 0987b88

Please sign in to comment.