Skip to content

Commit

Permalink
Make spelling of "initialize" consistent
Browse files Browse the repository at this point in the history
This will make searching easier as one does not have to check for
alternate spellings.

Fixes: #2486

Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
  • Loading branch information
fjeremic committed Jun 6, 2018
1 parent bfc5ed7 commit 5446842
Show file tree
Hide file tree
Showing 43 changed files with 101 additions and 101 deletions.
4 changes: 2 additions & 2 deletions compiler/aarch64/codegen/OMRMachine.cpp
Expand Up @@ -32,7 +32,7 @@ OMR::ARM64::Machine::Machine(TR::CodeGenerator *cg) :
OMR::Machine(cg, NUM_ARM64_GPR, NUM_ARM64_FPR)
{
_registerFile = (TR::RealRegister **)cg->trMemory()->allocateMemory(sizeof(TR::RealRegister *)*TR::RealRegister::NumRegisters, heapAlloc);
self()->initialiseRegisterFile();
self()->initializeRegisterFile();
}

TR::RealRegister *OMR::ARM64::Machine::findBestFreeRegister(TR_RegisterKinds rk,
Expand Down Expand Up @@ -132,7 +132,7 @@ void OMR::ARM64::Machine::coerceRegisterAssignment(TR::Instruction *currentInstr
TR_ASSERT(false, "Not implemented yet.");
}

void OMR::ARM64::Machine::initialiseRegisterFile()
void OMR::ARM64::Machine::initializeRegisterFile()
{
_registerFile[TR::RealRegister::NoReg] = NULL;
_registerFile[TR::RealRegister::SpilledReg] = NULL;
Expand Down
2 changes: 1 addition & 1 deletion compiler/aarch64/codegen/OMRMachine.hpp
Expand Up @@ -160,7 +160,7 @@ class OMR_EXTENSIBLE Machine : public OMR::Machine
TR::RealRegister::RegState _registerStatesSnapShot[TR::RealRegister::NumRegisters];
TR::Register *_assignedRegisterSnapShot[TR::RealRegister::NumRegisters];

void initialiseRegisterFile();
void initializeRegisterFile();

};
}
Expand Down
4 changes: 2 additions & 2 deletions compiler/arm/codegen/OMRMachine.cpp
Expand Up @@ -45,7 +45,7 @@ static void registerCopy(TR::Instruction *precedingI,

OMR::ARM::Machine::Machine(TR::CodeGenerator *cg): OMR::Machine(cg, NUM_ARM_GPR, NUM_ARM_FPR)
{
self()->initialiseRegisterFile();
self()->initializeRegisterFile();
}


Expand Down Expand Up @@ -619,7 +619,7 @@ void OMR::ARM::Machine::coerceRegisterAssignment(TR::Instruction
}


void OMR::ARM::Machine::initialiseRegisterFile()
void OMR::ARM::Machine::initializeRegisterFile()
{
self()->cg()->_unlatchedRegisterList =
(TR::RealRegister**)self()->cg()->trMemory()->allocateHeapMemory(sizeof(TR::RealRegister*)*(TR::RealRegister::NumRegisters + 1));
Expand Down
2 changes: 1 addition & 1 deletion compiler/arm/codegen/OMRMachine.hpp
Expand Up @@ -67,7 +67,7 @@ class OMR_EXTENSIBLE Machine : public OMR::Machine

static uint32_t _globalRegisterNumberToRealRegisterMap[MAX_ARM_GLOBAL_GPRS + MAX_ARM_GLOBAL_FPRS];

void initialiseRegisterFile();
void initializeRegisterFile();

// For register snap shot
uint16_t _registerFlagsSnapShot[TR::RealRegister::NumRegisters];
Expand Down
4 changes: 2 additions & 2 deletions compiler/codegen/OMRAheadOfTimeCompile.hpp
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2016 IBM Corp. and others
* Copyright (c) 2000, 2018 IBM Corp. and others
*
* This program and the accompanying materials are made available under
* the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -81,7 +81,7 @@ class OMR_EXTENSIBLE AheadOfTimeCompile
}

virtual void processRelocations() = 0;
virtual uint8_t *initialiseAOTRelocationHeader(TR::IteratedExternalRelocation *relocation) = 0;
virtual uint8_t *initializeAOTRelocationHeader(TR::IteratedExternalRelocation *relocation) = 0;

// virtual void dumpRelocationData() = 0;
void dumpRelocationData() {}
Expand Down
8 changes: 4 additions & 4 deletions compiler/codegen/Relocation.cpp
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2016 IBM Corp. and others
* Copyright (c) 2000, 2018 IBM Corp. and others
*
* This program and the accompanying materials are made available under
* the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -480,10 +480,10 @@ TR::IteratedExternalRelocation::IteratedExternalRelocation(uint8_t *target, uint
AOTcgDiag0(TR::comp(), "TR::IteratedExternalRelocation::IteratedExternalRelocation\n");
}

void TR::IteratedExternalRelocation::initialiseRelocation(TR::CodeGenerator *codeGen)
void TR::IteratedExternalRelocation::initializeRelocation(TR::CodeGenerator *codeGen)
{
AOTcgDiag0(TR::comp(), "TR::IteratedExternalRelocation::initialiseRelocation\n");
_relocationDataCursor = codeGen->getAheadOfTimeCompile()->initialiseAOTRelocationHeader(this);
AOTcgDiag0(TR::comp(), "TR::IteratedExternalRelocation::initializeRelocation\n");
_relocationDataCursor = codeGen->getAheadOfTimeCompile()->initializeAOTRelocationHeader(this);
}

void TR::IteratedExternalRelocation::addRelocationEntry(uint32_t locationOffset)
Expand Down
4 changes: 2 additions & 2 deletions compiler/codegen/Relocation.hpp
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2016 IBM Corp. and others
* Copyright (c) 2000, 2018 IBM Corp. and others
*
* This program and the accompanying materials are made available under
* the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -332,7 +332,7 @@ class IteratedExternalRelocation : public TR_Link<TR::IteratedExternalRelocation
uint8_t *getRelocationDataCursor() {return _relocationDataCursor;}
uint8_t *setRelocationDataCursor(uint8_t *p) {return (_relocationDataCursor = p);}

void initialiseRelocation(TR::CodeGenerator * codeGen);
void initializeRelocation(TR::CodeGenerator * codeGen);
void addRelocationEntry(uint32_t locationOffset);

uint16_t getSizeOfRelocationData() {return _sizeOfRelocationData;}
Expand Down
2 changes: 1 addition & 1 deletion compiler/env/TRMemory.hpp
Expand Up @@ -1148,7 +1148,7 @@ namespace TR
return offset;
}
private:
Metric _reading; // meter reading while metering, uninitialised on construction
Metric _reading; // meter reading while metering, uninitialized on construction
};

typedef CS2::RunnableMeter<AllocatedMemoryMeter> MemoryMeter;
Expand Down
4 changes: 2 additions & 2 deletions compiler/il/OMRILOpCodesEnum.hpp
Expand Up @@ -38,7 +38,7 @@


FirstOMROp,
BadILOp = 0, // illegal op hopefully help with uninitialised nodes
BadILOp = 0, // illegal op hopefully help with uninitialized nodes
aconst, // load address constant (zero value means NULL)
iconst, // load integer constant (32-bit signed 2's complement)
lconst, // load long integer constant (64-bit signed 2's complement)
Expand Down Expand Up @@ -653,7 +653,7 @@
Case, // case nodes that are children of TR_switch. Uses the branchdestination and the int const field
table, // tableswitch (child1 is the selector, child2 the default destination, subsequent children are the branch targets
// (the last child may be a branch table address, use getCaseIndexUpperBound() when iterating over branch targets)
exceptionRangeFence, // (J9) SymbolReference is the aliasing effect, initialiser is where the code address gets put when binary is generated
exceptionRangeFence, // (J9) SymbolReference is the aliasing effect, initializer is where the code address gets put when binary is generated
// used for delimiting function, try blocks, catch clauses, finally clauses, etc.
dbgFence, // used to delimit code (stmts) for debug info. Has no symbol reference.
NULLCHK, // Null check a pointer. child 1 is indirect reference. Symbolref indicates failure action/destination
Expand Down
4 changes: 2 additions & 2 deletions compiler/p/codegen/OMRMachine.cpp
Expand Up @@ -143,7 +143,7 @@ numLockedFPRs(-1),
numLockedVRFs(-1)
{
_registerFile = (TR::RealRegister **)cg->trMemory()->allocateMemory(sizeof(TR::RealRegister *)*TR::RealRegister::NumRegisters, heapAlloc);
self()->initialiseRegisterFile();
self()->initializeRegisterFile();
memset( _registerAssociations, 0, sizeof(TR::Register*)*TR::RealRegister::NumRegisters );
}

Expand Down Expand Up @@ -1318,7 +1318,7 @@ void OMR::Power::Machine::coerceRegisterAssignment(TR::Instruction
}


void OMR::Power::Machine::initialiseRegisterFile()
void OMR::Power::Machine::initializeRegisterFile()
{

_registerFile[TR::RealRegister::NoReg] = NULL;
Expand Down
2 changes: 1 addition & 1 deletion compiler/p/codegen/OMRMachine.hpp
Expand Up @@ -65,7 +65,7 @@ class OMR_EXTENSIBLE Machine : public OMR::Machine
TR::RealRegister **_registerFile;
TR::Register *_registerAssociations[TR::RealRegister::NumRegisters];

void initialiseRegisterFile();
void initializeRegisterFile();

int _4thLastGPRAssigned;
int _3rdLastGPRAssigned;
Expand Down
2 changes: 1 addition & 1 deletion compiler/x/codegen/OMRCodeGenerator.cpp
Expand Up @@ -324,7 +324,7 @@ OMR::X86::CodeGenerator::initialize(TR::Compilation *comp)

self()->setGlobalRegisterTable(self()->machine()->getGlobalRegisterTable(*_linkageProperties));

self()->machine()->initialiseRegisterFile(*_linkageProperties);
self()->machine()->initializeRegisterFile(*_linkageProperties);

self()->getLinkage()->copyLinkageInfoToParameterSymbols();

Expand Down
6 changes: 3 additions & 3 deletions compiler/x/codegen/OMRMachine.cpp
Expand Up @@ -192,7 +192,7 @@ OMR::X86::Machine::Machine
_globalRegisterNumberToRealRegisterMap(globalRegisterNumberToRealRegisterMap),
_spilledRegistersList(NULL)
{
self()->initialiseFPStackRegisterFile();
self()->initializeFPStackRegisterFile();
_fpTopOfStack = TR_X86FPStackRegister::fpStackEmpty;
self()->resetFPStackRegisters();
self()->resetXMMGlobalRegisters();
Expand Down Expand Up @@ -1580,7 +1580,7 @@ OMR::X86::Machine::createRegisterAssociationDirective(TR::Instruction *cursor)
#define UNUSED_WEIGHT 0xFFFF

void
OMR::X86::Machine::initialiseRegisterFile(const struct TR::X86LinkageProperties &properties)
OMR::X86::Machine::initializeRegisterFile(const struct TR::X86LinkageProperties &properties)
{
int reg;

Expand Down Expand Up @@ -2372,7 +2372,7 @@ void OMR::X86::Machine::resetFPStackRegisters()
}


void OMR::X86::Machine::initialiseFPStackRegisterFile()
void OMR::X86::Machine::initializeFPStackRegisterFile()
{
_fpStack[TR_X86FPStackRegister::fp0] = new (self()->cg()->trHeapMemory()) TR_X86FPStackRegister(TR_X86FPStackRegister::Free,
TR_X86FPStackRegister::fp0,
Expand Down
4 changes: 2 additions & 2 deletions compiler/x/codegen/OMRMachine.hpp
Expand Up @@ -123,15 +123,15 @@ class OMR_EXTENSIBLE Machine : public OMR::Machine
int32_t _fpStackShape[TR_X86FPStackRegister::NumRegisters];
int32_t _fpTopOfStack;

void initialiseFPStackRegisterFile();
void initializeFPStackRegisterFile();

protected:

uint32_t *_globalRegisterNumberToRealRegisterMap;


public:
void initialiseRegisterFile(const struct TR::X86LinkageProperties&);
void initializeRegisterFile(const struct TR::X86LinkageProperties&);
uint32_t* getGlobalRegisterTable(const struct TR::X86LinkageProperties&);
int32_t getGlobalReg(TR::RealRegister::RegNum reg);

Expand Down
2 changes: 1 addition & 1 deletion compiler/x/codegen/OMRTreeEvaluator.cpp
Expand Up @@ -3448,7 +3448,7 @@ TR::Register *OMR::X86::TreeEvaluator::BBEndEvaluator(TR::Node *node, TR::CodeGe
{
// We need to record the final state of the register associations at the end
// of each extended basic block so that the register states and weights
// are initialised properly at the bottom of the block by the GP register
// are initialized properly at the bottom of the block by the GP register
// assigner.
//
TR::Machine *machine = cg->machine();
Expand Down
6 changes: 3 additions & 3 deletions compiler/z/codegen/OMRMachine.cpp
Expand Up @@ -733,7 +733,7 @@ OMR::Z::Machine::Machine(TR::CodeGenerator * cg)
_globalReturnAddressRegisterNumber(-1),_globalEntryPointRegisterNumber(-1)
,_lastGlobalHPRRegisterNumber(-1), _firstGlobalHPRRegisterNumber(-1)
{
self()->initialiseRegisterFile();
self()->initializeRegisterFile();
self()->initializeFPRegPairTable();
self()->clearRegisterAssociations();
}
Expand Down Expand Up @@ -6027,10 +6027,10 @@ uint64_t OMR::Z::Machine::filterColouredRegisterConflicts(TR::Register *targetRe


////////////////////////////////////////////////////////////////////////////////
// OMR::Z::Machine::initialiseRegisterFile
// OMR::Z::Machine::initializeRegisterFile
////////////////////////////////////////////////////////////////////////////////
void
OMR::Z::Machine::initialiseRegisterFile()
OMR::Z::Machine::initializeRegisterFile()
{

// Initialize GPRs
Expand Down
2 changes: 1 addition & 1 deletion compiler/z/codegen/OMRMachine.hpp
Expand Up @@ -228,7 +228,7 @@ class OMR_EXTENSIBLE Machine : public OMR::Machine
TR_GlobalRegisterNumber _globalEntryPointRegisterNumber;
TR_GlobalRegisterNumber _globalReturnAddressRegisterNumber;

void initialiseRegisterFile();
void initializeRegisterFile();
void initializeFPRegPairTable();

public:
Expand Down
2 changes: 1 addition & 1 deletion compiler/z/codegen/OMRTreeEvaluator.cpp
Expand Up @@ -11558,7 +11558,7 @@ OMR::Z::TreeEvaluator::fenceEvaluator(TR::Node * node, TR::CodeGenerator *cg)
}

/**
* exceptionRangeFenceEvaluator - SymbolReference is the aliasing effect, initialiser is where the
* exceptionRangeFenceEvaluator - SymbolReference is the aliasing effect, initializer is where the
* code address gets put when binary is generated
*/
TR::Register *
Expand Down
4 changes: 2 additions & 2 deletions doc/ValgrindMemcheckAPI.md
@@ -1,5 +1,5 @@
<!--
Copyright (c) 2017, 2017 IBM Corp. and others
Copyright (c) 2017, 2018 IBM Corp. and others
This program and the accompanying materials are made available under
the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -67,7 +67,7 @@ All api requests are made using a wrapper file `MemcheckWrapper.cpp`. Refer `Mem
## Running Valgrind

1. **Preparing Makefiles** - To compile with valgrind API enabled, use build option `--enable-OMR_VALGRIND_MEMCHECK` while generating makefiles. Valgrind documentation also recommends turning off optimizations. Their docs say:
> If you are planning to use Memcheck: On rare occasions, compiler optimisations (at -O2 and above, and sometimes -O1) have been observed to generate code which fools Memcheck into wrongly reporting uninitialised value errors.
> If you are planning to use Memcheck: On rare occasions, compiler optimisations (at -O2 and above, and sometimes -O1) have been observed to generate code which fools Memcheck into wrongly reporting uninitialized value errors.
So for given example, makefiles are generated by:

Expand Down
4 changes: 2 additions & 2 deletions fvtest/rastest/subscriberForkTest.cpp
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2015, 2016 IBM Corp. and others
* Copyright (c) 2015, 2018 IBM Corp. and others
*
* This program and the accompanying materials are made available under
* the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -169,7 +169,7 @@ preforkSetup(OMR_VMThread **vmthread, struct OMR_Agent **agent, OMRTestVM *testV
OMRTEST_ASSERT_ERROR_NONE(omr_agent_openLibrary(*agent));
OMRTEST_ASSERT_ERROR_NONE(omr_agent_callOnLoad(*agent));

/* Initialise the omr_test module for tracing */
/* Initialize the omr_test module for tracing */
UT_OMR_TEST_MODULE_LOADED(testVM->omrVM._trcEngine->utIntf);

/* Initialize pipe before fork. */
Expand Down
6 changes: 3 additions & 3 deletions fvtest/rastest/subscriberTest.cpp
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2014, 2015 IBM Corp. and others
* Copyright (c) 2014, 2018 IBM Corp. and others
*
* This program and the accompanying materials are made available under
* the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -66,7 +66,7 @@ TEST(RASSubscriberTest, SubscriberAgent)

OMRTEST_ASSERT_ERROR_NONE(omr_agent_callOnLoad(agent));

/* Initialise the omr_test module for tracing */
/* Initialize the omr_test module for tracing */
UT_OMR_TEST_MODULE_LOADED(testVM.omrVM._trcEngine->utIntf);

/* Fire some trace points! */
Expand All @@ -90,7 +90,7 @@ TEST(RASSubscriberTest, SubscriberAgent)

OMRTEST_ASSERT_ERROR_NONE(omr_agent_callOnLoad(agent));

/* Initialise the omr_test module for tracing */
/* Initialize the omr_test module for tracing */
UT_OMR_TEST_MODULE_LOADED(testVM.omrVM._trcEngine->utIntf);

/* Fire some trace points! */
Expand Down
4 changes: 2 additions & 2 deletions fvtest/rastest/traceLifecycleTest.cpp
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2015, 2016 IBM Corp. and others
* Copyright (c) 2015, 2018 IBM Corp. and others
*
* This program and the accompanying materials are made available under
* the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -281,7 +281,7 @@ TEST(TraceLifecycleTest, traceAndModuleUnloadAfterTraceShutdown)
OMRTEST_ASSERT_ERROR_NONE(
ti->RegisterRecordSubscriber(vmthread, "traceAndModuleUnloadAfterTraceShutdown", countTracepointsMT, NULL, (void *)&tpCountsMT, &subscriptionID));

/* Initialise the omr_test module for tracing */
/* Initialize the omr_test module for tracing */
UT_OMR_TEST_MODULE_LOADED(testVM.omrVM._trcEngine->utIntf);

/* Shut down the trace engine */
Expand Down
4 changes: 2 additions & 2 deletions fvtest/rastest/traceLogTest.cpp
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2015, 2016 IBM Corp. and others
* Copyright (c) 2015, 2018 IBM Corp. and others
*
* This program and the accompanying materials are made available under
* the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -189,7 +189,7 @@ TEST(TraceLogTest, stressTraceBufferManagement)
OMRTEST_ASSERT_ERROR_NONE(omr_agent_openLibrary(agent));
OMRTEST_ASSERT_ERROR_NONE(omr_agent_callOnLoad(agent));

/* Initialise the omr_test module for tracing */
/* Initialize the omr_test module for tracing */
UT_OMR_TEST_MODULE_LOADED(testVM.omrVM._trcEngine->utIntf);

OMRTEST_ASSERT_ERROR_NONE(
Expand Down
4 changes: 2 additions & 2 deletions fvtest/rastest/traceOptionTest.cpp
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2014, 2015 IBM Corp. and others
* Copyright (c) 2014, 2018 IBM Corp. and others
*
* This program and the accompanying materials are made available under
* the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -66,7 +66,7 @@ TEST(RASTraceOptionTest, TraceOptionAgent)

OMRTEST_ASSERT_ERROR_NONE(omr_agent_callOnLoad(agent));

/* Initialise the omr_test module for tracing */
/* Initialize the omr_test module for tracing */
UT_OMR_TEST_MODULE_LOADED(testVM.omrVM._trcEngine->utIntf);

/* Fire some trace points! */
Expand Down
2 changes: 1 addition & 1 deletion fvtest/rastest/traceTest.cpp
Expand Up @@ -83,7 +83,7 @@ TEST(RASTraceTest, TraceAgent)
}
#endif /* TEST_TRACEAGENT */

/* Initialise the omr_test module for tracing */
/* Initialize the omr_test module for tracing */
UT_OMR_TEST_MODULE_LOADED(testVM.omrVM._trcEngine->utIntf);

/* Fire some trace points! */
Expand Down

0 comments on commit 5446842

Please sign in to comment.