Skip to content

Commit

Permalink
Skip iselect + bcmp* and scmp* tests on x86
Browse files Browse the repository at this point in the history
The x86 codegen currently has a known bug with sub-integer compares as
the first child of an integral select opcode. The tests for this have
been temporarily disabled until this can be resolved.

Signed-off-by: Ben Thomas <ben@benthomas.ca>
  • Loading branch information
aviansie-ben committed Sep 2, 2020
1 parent 0987b88 commit d1a2969
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions fvtest/compilertriltest/SelectTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1354,6 +1354,8 @@ TEST_P(Int32SelectInt8CompareTest, UsingLoadParam) {
SKIP_ON_ARM(MissingImplementation);
SKIP_ON_S390(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_S390X(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_X86(KnownBug) << "The x86 code generator returns wrong results when a sub-integer compare is the first child of a select (#5501)";
SKIP_ON_HAMMER(KnownBug) << "The x86 code generator returns wrong results when a sub-integer compare is the first child of a select (#5501)";

auto param = to_struct(GetParam());

Expand Down Expand Up @@ -1386,6 +1388,8 @@ TEST_P(Int32SelectInt8CompareTest, UsingConstCompare) {
SKIP_ON_ARM(MissingImplementation);
SKIP_ON_S390(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_S390X(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_X86(KnownBug) << "The x86 code generator returns wrong results when a sub-integer compare is the first child of a select (#5501)";
SKIP_ON_HAMMER(KnownBug) << "The x86 code generator returns wrong results when a sub-integer compare is the first child of a select (#5501)";

auto param = to_struct(GetParam());

Expand Down Expand Up @@ -1419,6 +1423,8 @@ TEST_P(Int32SelectInt8CompareTest, UsingConstValues) {
SKIP_ON_ARM(MissingImplementation);
SKIP_ON_S390(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_S390X(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_X86(KnownBug) << "The x86 code generator returns wrong results when a sub-integer compare is the first child of a select (#5501)";
SKIP_ON_HAMMER(KnownBug) << "The x86 code generator returns wrong results when a sub-integer compare is the first child of a select (#5501)";

auto param = to_struct(GetParam());

Expand Down Expand Up @@ -1461,6 +1467,8 @@ TEST_P(Int32SelectInt16CompareTest, UsingLoadParam) {
SKIP_ON_ARM(MissingImplementation);
SKIP_ON_S390(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_S390X(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_X86(KnownBug) << "The x86 code generator returns wrong results when a sub-integer compare is the first child of a select (#5501)";
SKIP_ON_HAMMER(KnownBug) << "The x86 code generator returns wrong results when a sub-integer compare is the first child of a select (#5501)";

auto param = to_struct(GetParam());

Expand Down Expand Up @@ -1493,6 +1501,8 @@ TEST_P(Int32SelectInt16CompareTest, UsingConstCompare) {
SKIP_ON_ARM(MissingImplementation);
SKIP_ON_S390(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_S390X(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_X86(KnownBug) << "The x86 code generator returns wrong results when a sub-integer compare is the first child of a select (#5501)";
SKIP_ON_HAMMER(KnownBug) << "The x86 code generator returns wrong results when a sub-integer compare is the first child of a select (#5501)";

auto param = to_struct(GetParam());

Expand Down Expand Up @@ -1526,6 +1536,8 @@ TEST_P(Int32SelectInt16CompareTest, UsingConstValues) {
SKIP_ON_ARM(MissingImplementation);
SKIP_ON_S390(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_S390X(KnownBug) << "The Z code generator crashes when a sub-integer compare is the first child of an integral select (#5499)";
SKIP_ON_X86(KnownBug) << "The x86 code generator returns wrong results when a sub-integer compare is the first child of a select (#5501)";
SKIP_ON_HAMMER(KnownBug) << "The x86 code generator returns wrong results when a sub-integer compare is the first child of a select (#5501)";

auto param = to_struct(GetParam());

Expand Down

0 comments on commit d1a2969

Please sign in to comment.