Refactor Power l2aEvaluator #2240
Labels
Comments
|
I don't recall seeing this sort of prefetch being emitted lately. The logic in |
IBMJimmyk
added a commit
to IBMJimmyk/omr
that referenced
this issue
Jun 5, 2018
This removes addPrefetch from OMR. It is replaced by a call to the method insertPrefetchIfNecessary. By default insertPrefetchIfNecessary just returns. Extending projects can override it to add functionality. iloadEvaluator and l2aEvaluator were also modified to now use insertPrefetchIfNecessary instead of addPrefetch. Prefetch was added to iloadEvaluator on Power because it was shown to improve performance on an internal appserver benchmark. The OpenJ9 changes will be handled by a pull request in OpenJ9. Issue: eclipse#2240 Issue: eclipse#2634 Signed-off-by: jimmyk <jimmyk@ca.ibm.com>
IBMJimmyk
added a commit
to IBMJimmyk/omr
that referenced
this issue
Jun 18, 2018
This removes addPrefetch from OMR. It is replaced by a call to the method insertPrefetchIfNecessary. By default insertPrefetchIfNecessary just returns. Extending projects can override it to add functionality. iloadEvaluator and l2aEvaluator were also modified to now use insertPrefetchIfNecessary instead of addPrefetch. Prefetch was added to iloadEvaluator on Power because it was shown to improve performance on an internal appserver benchmark. The OpenJ9 changes will be handled by a pull request in OpenJ9. Issue: eclipse#2240 Issue: eclipse#2634 Signed-off-by: jimmyk <jimmyk@ca.ibm.com>
IBMJimmyk
added a commit
to IBMJimmyk/omr
that referenced
this issue
Jun 18, 2018
This removes addPrefetch from OMR. It is replaced by a call to the method insertPrefetchIfNecessary. By default insertPrefetchIfNecessary just returns. Extending projects can override it to add functionality. iloadEvaluator and l2aEvaluator were also modified to now use insertPrefetchIfNecessary instead of addPrefetch. Prefetch was added to iloadEvaluator on Power because it was shown to improve performance on an internal appserver benchmark. The OpenJ9 changes will be handled by a pull request in OpenJ9. Issue: eclipse#2240 Issue: eclipse#2634 Signed-off-by: jimmyk <jimmyk@ca.ibm.com>
0dvictor
pushed a commit
to 0dvictor/omr
that referenced
this issue
Jun 19, 2018
This removes addPrefetch from OMR. It is replaced by a call to the method insertPrefetchIfNecessary. By default insertPrefetchIfNecessary just returns. Extending projects can override it to add functionality. iloadEvaluator and l2aEvaluator were also modified to now use insertPrefetchIfNecessary instead of addPrefetch. Prefetch was added to iloadEvaluator on Power because it was shown to improve performance on an internal appserver benchmark. The OpenJ9 changes will be handled by a pull request in OpenJ9. Issue: eclipse#2240 Issue: eclipse#2634 Signed-off-by: jimmyk <jimmyk@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
OMR::Power::TreeEvaluator::l2aEvaluatorcontains an undocumented specialty optimization to insert a prefetch when compiled at scorching for a compressed reference sequence. I believe this is an optimization specific to OpenJ9, and hence this function should be refactored to remove it from OMR. TheaddPrefetchlogic (and its dependencies) should also be relocated to OpenJ9.@ymanton @gita-omr : do you have any insight on the purpose of this prefetch at scorching and whether it actually would be generally useful?
The text was updated successfully, but these errors were encountered: