Change TR_ASSERT_FATAL to static_assert in TR_AliasSetInterface

[Leonardo2718]

There are some instances of TR_ASSERT_FATAL in TR_AliasSetInterface [1,2,3] that should really be static_asserts. _AliasSetInterface is a template parameter so its value is known at compile time. Therefore, _AliasSetInterface == UseDefAliasSet || _AliasSetInterface == UseOnlyAliasSet can also be checked at compile time.

Note: the AliasSetInterface enum only has UseDefAliasSet and UseOnlyAliasSet as variants, so _AliasSetInterface == UseDefAliasSet || _AliasSetInterface == UseOnlyAliasSet may seem like a tautology. Unfortunatly, C++ allows casting arbitraty integers values to enum types, so it's possible to have code like TR_AliastSetInterface<(AliasSetInterface)42>. As a result, checking that the value of _AliasSetInterface makes sense is still a good idea.

[1]

omr/compiler/il/AliasSetInterface.hpp

Line 259 in 5384dad

TR_ASSERT_FATAL(_AliasSetInterface == UseDefAliasSet || _AliasSetInterface == UseOnlyAliasSet, "failed: can only call setAliases_impl for UseOnly or useDef presently");

[2]

omr/compiler/il/AliasSetInterface.hpp

Line 277 in 5384dad

TR_ASSERT_FATAL(_AliasSetInterface == UseDefAliasSet || _AliasSetInterface == UseOnlyAliasSet, "failed: can only call removeAllAliases for UseOnly or useDef presently");

[3]

omr/compiler/il/AliasSetInterface.hpp

Line 360 in 5384dad

TR_ASSERT_FATAL(_AliasSetInterface == UseDefAliasSet || _AliasSetInterface == UseOnlyAliasSet, "failed: can only call setAlias_impl for UseOnly or useDef presently");

[PaulinaQuintero]

Hi! I'm starting off contributing to open source. Can I check this?

[fjeremic]

@PaulinaQuintero sure, we're always happy to accept new contributions! Feel free to open up a PR if you wish to tackle this one.

[PaulinaQuintero]

I made a pull request with the changes that are requested but when making the tets it marks 6 errors in the porttest when I run the ctest, do you know why and how can I solve this? I would appreciate your help with this

[Leonardo2718]

@PaulinaQuintero

Those port library test failures are unrelated to your change (I suspect they will fail without your change too). It should be safe for you to re-open your PR. When the CI tests run, we can verify that those failures are not your problem.