Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate setting of SIMD enablement flag on Z to OMR #6572

Closed
r30shah opened this issue Jun 15, 2022 · 0 comments · Fixed by #6606
Closed

Migrate setting of SIMD enablement flag on Z to OMR #6572

r30shah opened this issue Jun 15, 2022 · 0 comments · Fixed by #6606

Comments

@r30shah
Copy link
Contributor

r30shah commented Jun 15, 2022 •
edited
Loading

Currently codegenerator on Z checks if the platform has vector facilities installed and sets up the correct flag that is used throughout the codebase in both OMR and OpenJ9. ATM these checks are done in OpenJ9 weirdly in while constructing the Private Linkage [1]. This kind of general platform checks should be migrated to OMR, although simply moving them to OMRGenerator leads to segmentation fault in JIT codegen. I am opening up this issue to keep track and document the reasons behind those failure. More details can be found in [2]

[1]. https://github.com/eclipse-openj9/openj9/blob/4ca209b54385134923881152273150eaf4847ac9/runtime/compiler/z/codegen/S390PrivateLinkage.cpp#L104-L113
[2]. #6558 (comment)
@r30shah r30shah mentioned this issue Jun 15, 2022
Merged
r30shah added a commit to r30shah/omr that referenced this issue Jul 12, 2022
@r30shah
Set Vector Support in OMR
5fb8cfe 
While constructing a code generator object, check for vector facility
and set appropriate options. This check was done previously in
S390PrivateLinkage in OpenJ9, which would be incorrect place to do so.

Fixes: eclipse#6572

Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
@r30shah r30shah mentioned this issue Jul 12, 2022
Merged
r30shah added a commit to r30shah/omr that referenced this issue Jul 18, 2022
@r30shah
Set Vector Support in OMR
c262e37 
While constructing a code generator object, check for vector facility
and set appropriate options. This check was done previously in
S390PrivateLinkage in OpenJ9, which would be incorrect place to do so.

Fixes: eclipse#6572

Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set Vector Support in OMR r30shah/omr
1 participant
@r30shah