Set Vector Support in OMR #6606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While constructing a code generator object, check for vector facility and set appropriate options. This check was done previously in S390PrivateLinkage in OpenJ9, which would be incorrect place to do so. Fixes: eclipse#6572 Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
r30shah
force-pushed
the
fixVectorSupportChecks
branch
from
5fb8cfe
to
c262e37
Compare
|
@joransiu Can I please get a review on this one ? Java 8 Build : |
|
Jenkins build zlinux zos |
|
@0xdaryl Can I request you to review and merge this changes as builds are finished? I have also posted build ids in #6606 (comment) for the personal builds for reference. |
0xdaryl
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While constructing a code generator object, check for vector facility
and set appropriate options. This check was done previously in
S390PrivateLinkage in OpenJ9, which would be incorrect place to do so.
Fixes: #6572
Signed-off-by: Rahil Shah rahil@ca.ibm.com