Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCS Lock (Part 1) #4484

Merged
merged 5 commits into from
Oct 28, 2019
Merged

MCS Lock (Part 1) #4484

merged 5 commits into from
Oct 28, 2019

Conversation

babsingh
Copy link
Contributor

  1. Add new data structures and macros for implementing MCS locks.
  2. Add a field to a store a OMRThreadMCSNodes pointer in J9Thread.
  3. Add a field to store a pointer to the MCS queue tail in J9ThreadMonitor.
  4. Add function prototypes for the MCS lock API.
  5. Add function stubs with description for the MCS lock API.
  6. [DONT MERGE] Enable the OMR_THR_MCS_LOCKS flag to verify compilation.

Will remove 6) after it is verified that the code compiles properly through the pull request build jobs.

Related: #4086.

Signed-off-by: Babneet Singh sbabneet@ca.ibm.com

@rwy7
Copy link
Member

rwy7 commented Oct 18, 2019

@genie-omr build all

@rwy7 rwy7 changed the title MCS Locks: Part 1 WIP: MCS Locks: Part 1 Oct 18, 2019
@babsingh babsingh force-pushed the mcs_structs_api branch 3 times, most recently from fef8dbd to 5dee974 Compare October 18, 2019 21:15
@babsingh babsingh changed the title WIP: MCS Locks: Part 1 MCS Locks: Part 1 Oct 18, 2019
@rwy7
Copy link
Member

rwy7 commented Oct 18, 2019

@genie-omr build all

@vijaysun-omr vijaysun-omr self-assigned this Oct 21, 2019
@babsingh babsingh mentioned this pull request Oct 24, 2019
Merged
@babsingh babsingh force-pushed the mcs_structs_api branch 4 times, most recently from 7754d55 to 7052754 Compare October 24, 2019 19:43
@babsingh
Add new data structures and macros for implementing MCS locks
3f4ee6f 
The code is wrapped using OMR_THR_MCS_LOCKS ifdefs.

Refer to the description in eclipse#4086 for
more details.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Add a field to a store a OMRThreadMCSNodes pointer in J9Thread
904ecbb 
Related: eclipse#4086.

The code is wrapped using OMR_THR_MCS_LOCKS ifdefs.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Add a field to store a pointer to the MCS queue tail in J9ThreadMonitor
80ed090 
queueTail corresponds to the queue tail of the MCS nodes.

Related: eclipse#4086.

The code is wrapped using OMR_THR_MCS_LOCKS ifdefs.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Add function prototypes for the MCS lock API
dd1d8da 
Related: eclipse#4086.

The code is wrapped using OMR_THR_MCS_LOCKS ifdefs.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Add function stubs with description for the MCS lock API
a5fca84 
Related: eclipse#4086.

The code is wrapped using OMR_THR_MCS_LOCKS ifdefs.
    
Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@rwy7
Copy link
Member

rwy7 commented Oct 28, 2019

@genie-omr build all

@vijaysun-omr vijaysun-omr assigned rwy7 and unassigned vijaysun-omr Oct 28, 2019
@babsingh
Copy link
Contributor Author

@rwy0717 The previous build all passed. So, I have removed the top commit, 6). The PR is ready to be merged.

@rwy7 rwy7 merged commit 15996ba into eclipse:master Oct 28, 2019
@babsingh babsingh changed the title MCS Locks: Part 1 MCS Lock (Part 1) Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwy7 rwy7 rwy7 approved these changes

@charliegracie charliegracie Awaiting requested review from charliegracie

@mstoodle mstoodle Awaiting requested review from mstoodle mstoodle is a code owner

@youngar youngar Awaiting requested review from youngar

Assignees

@rwy7 rwy7

Labels
comp:thread
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@babsingh @rwy7 @Leonardo2718 @vijaysun-omr