Remove method with definite value for simplicity #5409
Conversation
jamesgua
requested review from
0xdaryl,
andrewcraik,
mstoodle and
vijaysun-omr
as code owners
compiler/infra/SimpleRegex.cpp
Outdated
| @@ -475,10 +475,8 @@ bool SimpleRegex::match( | |||
| bool isCaseSensitive) | |||
| { | |||
| TR::Compilation *comp = TR::comp(); | |||
| TR::StackMemoryRegion stackMemoryRegion(*comp->trMemory()); | |||
There was a problem hiding this comment.
This changes the memory lifetime of the data returned from signature and, possibly regex - why the change?
There was a problem hiding this comment.
Didn't realize the destructor will unregister the region, I was thinking it's unused instance, will revert the change and update.
|
Was the last commit supposed to address the review? I don't see the region being restored when I am looking at the code on github... |
|
Struggling with messed commits, still learning to merge them properly. |
|
@andrewcraik Now pls take a look of updated PR. |
|
@genie-omr build all |
|
@jamesgua I see you have added an extra commit with changes unrelated to the PR - can you please remove them and open a new PR for those if you wish to contribute them? We try to keep each PR to a logical change and these two changes appear to be unrelated. |
|
@jamesgua have you had a chance to look at this? The contribution you were looking to make would be welcome - if you could remove the unrelated change we can look to retest and accept the contribution - thanks! |
those methods return false and not referenced in other places except local
remove unused variable in member function
Signed-off-by: James Guan jamesgua@ca.ibm.com