Define isArrayCompTypeValueType method for Value Propagation #5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a virtual method and base implementation of isArrayCompTypeValueType to OMR::ValuePropagation that can be used to determine whether the component type of an array is definitely, might be or is definitely not a value type. The base implementation simply assumes any array's component type might be a value type if value type support is enabled, and that it is definitely not a value type otherwise. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
|
FYI @Leonardo2718, @a7ehuo, @vijaysun-omr, @0xdaryl - this pull request replaces my recently withdrawn pull request #5904. Corrections to the implementation of |
|
Jenkins build all |
0xdaryl
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a virtual method and base implementation of
isArrayCompTypeValueTypetoOMR::ValuePropagationthat can be used to determine whether the component type of an array is definitely, might be or is definitely not a value type.The base implementation simply assumes any array's component type might be a value type if value type support is enabled, and that it is definitely not a value type otherwise.