Fix warnings on s390x #6077
Fix warnings on s390x #6077
Conversation
fjeremic
requested review from
0xdaryl,
Leonardo2718 and
mstoodle
as code owners
fjeremic
force-pushed
the
s390-warnings
branch
2 times, most recently
from
6a8ac5e
to
a7a9dfb
Compare
```
warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘intptr_t {aka long int}’ [-Wformat=]
```
``` warning: converting to non-pointer type ‘long unsigned int’ from NULL [-Wconversion-null] ```
fjeremic
force-pushed
the
s390-warnings
branch
2 times, most recently
from
56c947d
to
d56a233
Compare
fjeremic
force-pushed
the
s390-warnings
branch
2 times, most recently
from
ebcbc5e
to
eca1462
Compare
fjeremic
force-pushed
the
s390-warnings
branch
2 times, most recently
from
5a9c7fa
to
02c2857
Compare
``` warning: comparison between ‘enum OMR::RealRegister::RegNum’ and ‘enum OMR::RealRegister::RegDep’ [-Wenum-compare] ```
See eclipse#1662 for some further details. This will not be easy to solve becalse it is not straightforward to covert `TR::JitConfig` to a POD so we can use `offsetof`. This will hopefully be solved via the options framework overhaul, so fixing this warning properly is not worth the effort at the moment. Instead we locally disable this warning around the problematic area.
``` CCN5216 (W) An expression of type "void *" cannot be converted to type "void (*)(int, int, int *)". ```
fjeremic
changed the title
``` CCN6101 (W) A return value of type "bool" is expected. ```
``` CCN6404 (W) The parameter "OS" specified for "pragma linkage" is not valid. The pragma is ignored. ``` According to the documentation `#pragma linkage` is only valid for C compilation units.
fjeremic
force-pushed
the
s390-warnings
branch
5 times, most recently
from
04a6b1e
to
e1077c4
Compare
|
Jenkins build all |
|
@dsouzai this one should be ready. |
There was a problem hiding this comment.
LGTM; however, could you add a more descriptive message to the last commit (e1077c4); (ignoring the copyright updates) it seems to do more than just dealing with the non-POD class type passed in through ellipses (ie, the qasm and the __yield/__nop definitions)
|
Noting all tests passed, so a commit message change does not require running all the tests again. |
Good catch. This seems like a mistake by me squashing commits and wrestling with xlC trying to get things to work. Going to fix this up now. I will likely split this into two commits as the warning number is incorrect. There will be no functional change, but we can run the testing again as it's fairly quick. |
``` CCN8924 (W) Cannot pass an argument of non-POD class type "TR::DataType" through ellipsis. ```
``` CCN5562 (W) No code is generated for the asm statement. The asm statement is ignored. ``` Assembly generation for C/C++ code is disabled by default unless the `-qasm` flag is set. The above warning was telling us the inline assembly code was not generating anything, which is definitely not what we want. Enabling `-qasm` further exposes bugs with the syntax for inline assembly on xlC which is why the changes in AtomicSupport.cpp were needed.
|
I force pushed the changes. As seen the force-push contains no actual code change. I've merely split the last commit into two, to isolate the Jenkins build all |
A series of commits which address warnings on Linux and z/OS s390 targets.