Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultValueSymbol for value type class #6530

Merged
merged 1 commit into from
May 26, 2022

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented May 25, 2022

defaultValueSymbol symbol represents the defaultValue field in J9Class.flattenedClassCache.

Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com

@a7ehuo
Copy link
Contributor Author

a7ehuo commented May 25, 2022

This change is required by eclipse-openj9/openj9#15118 and should be reviewed along with eclipse-openj9/openj9#15118.

@hzongaro @0xdaryl May I ask you to review? Thanks!

@a7ehuo a7ehuo requested review from hzongaro and removed request for mstoodle May 25, 2022 21:05
@0xdaryl
Copy link
Contributor

0xdaryl commented May 26, 2022

Jenkins build all

1 similar comment
@0xdaryl
Copy link
Contributor

0xdaryl commented May 26, 2022

Jenkins build all

@0xdaryl 0xdaryl self-assigned this May 26, 2022
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a really minor comment on the description of the symbol. I'm not sure whether it's worth the bother to change it, or even whether my suggestion is really any better.

compiler/compile/OMRNonHelperSymbols.enum Outdated Show resolved Hide resolved
This symbol is used to access the default instance
associated with a class, if any exists.

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@0xdaryl
Copy link
Contributor

0xdaryl commented May 26, 2022

Latest push is a comment change only. Not re-running CI. Merging.

@0xdaryl 0xdaryl merged commit 6843751 into eclipse:master May 26, 2022
@a7ehuo a7ehuo deleted the defaultvalue-symbol branch October 12, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants