Add options to control the costs of collecting thread stack traces #6629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
requested review from
charliegracie,
youngar,
rwy7 and
mstoodle
as code owners
github-actions
bot
added
arch:power
arch:x86
arch:z
comp:core
comp:port
os:aix
os:linux
os:macos
os:windows
os:ztpf
labels
|
@babsingh : please review |
babsingh
requested review from
babsingh
and removed request for
rwy7,
youngar,
mstoodle and
charliegracie
babsingh
requested changes
Aug 2, 2022
Allow separation of symbol resolution from collecting stack traces. Don't call introspect_backtrace_symbols() if OMR_INTROSPECT_NO_SYMBOLS is specified in J9ThreadWalkState.options given to omrintrospect_threads_*(). Add introspect_backtrace_symbols_ex() which accepts options, the first of which, OMR_BACKTRACE_SYMBOLS_BASIC, controls the cost of symbol resolution. Currently, this is only meaningful on Linux where full symbol resolution can be costly. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
Updated based on review feedback. |
|
jenkins build all |
|
The last successful plinux PR build was on July 19; all have failed since so I don't think it has anything to do with this. |
Yes, it is a known issue; unrelated to this PR. #6556 matches this failure. |
|
Pinged @AdamBrousseau since all OMR zOS nodes are offline. |
babsingh
approved these changes
Aug 3, 2022
|
The zOS build has passed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow separation of symbol resolution from collecting stack traces. Don't call
introspect_backtrace_symbols()ifOMR_INTROSPECT_NO_SYMBOLSis specified inJ9ThreadWalkState.optionsgiven toomrintrospect_threads_*().Add
introspect_backtrace_symbols_ex()which accepts options, the first of which,OMR_BACKTRACE_SYMBOLS_BASIC, controls the cost of symbol resolution. Currently, this is only meaningful on Linux where full symbol resolution can be costly.