Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct definition of omrintrospect_threads_nextDo() #6626

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Correct definition of omrintrospect_threads_nextDo() #6626

merged 1 commit into from
Jul 27, 2022

Conversation

keithc-ca
Copy link
Contributor

Also remove duplicate declaration.

@keithc-ca
Correct definition of omrintrospect_threads_nextDo()
f3359e0 
Also remove duplicate declaration.

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@babsingh
Copy link
Contributor

jenkins build all

@babsingh
Copy link
Contributor

https://ci.eclipse.org/omr/job/PullRequest-linux_ppc-64_le_gcc/3720/console

Known failure: #6571

babsingh
babsingh approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keithc-ca How was this issue identified: visual inspection?

@babsingh babsingh merged commit a7dd4af into eclipse-omr:master Jul 27, 2022
@keithc-ca
Copy link
Contributor Author

@keithc-ca How was this issue identified: visual inspection?

I am working on changes to omrintrospect_threads_*Do that will allow symbol resolution to be optional, and omrintrospect_backtrace_symbols_ex which will accept an option that can be used to suppress the (expensive part of) symbol resolution added in #6345. In the OpenJ9 change to make use of it, I intend to remove the j9introspect_* macros in favour of using the ones defined by OMR, but this fix was needed for that to be possible.

@keithc-ca keithc-ca deleted the threads_nextDo branch July 27, 2022 13:34
@keithc-ca
Copy link
Contributor Author

#6629 contains the changes I spoke about in #6626 (comment).

@keithc-ca keithc-ca mentioned this pull request Aug 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babsingh babsingh babsingh approved these changes

@charliegracie charliegracie Awaiting requested review from charliegracie

@youngar youngar Awaiting requested review from youngar

@rwy7 rwy7 Awaiting requested review from rwy7

@mstoodle mstoodle Awaiting requested review from mstoodle mstoodle is a code owner

Assignees
No one assigned
Labels
comp:core comp:port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithc-ca @babsingh