Add API for performing analysis in Liveness #6642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xdaryl tagging you here just so you'll see this when you're ready. |
0xdaryl
reviewed
Aug 5, 2022
| @@ -852,6 +852,7 @@ class TR_Liveness : public TR_BackwardUnionBitVectorAnalysis | |||
| TR_LiveVariableInformation *getLiveVariableInfo() { return _liveVariableInfo; } | |||
| virtual Kind getKind(); | |||
| virtual TR_Liveness *asLiveness(); | |||
| virtual void perform(TR_Structure *rootStructure) {} | |||
There was a problem hiding this comment.
Could you add a Doxygen comment to this API? e.g.,
/**
* @brief Perform a liveness analysis on the given \c TR_Structure
*
* @param[in] rootStructure : \c TR_Structure to perform a liveness analysis over
*
* @return none
*/
There was a problem hiding this comment.
Sure, I've added the comment.
-empty implementation to prepare for future commit that splits out analysis from the constructor
kevindean12
force-pushed
the
perform-liveness
branch
from
3c4a92a
to
dd90a43
Compare
|
Jenkins build all |
0xdaryl
approved these changes
Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a perform() method with empty implementation in TR_Liveness to prepare for PR #6612 that splits out analysis from the constructor.