Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for performing analysis in Liveness #6642

Merged
merged 1 commit into from
Aug 7, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion compiler/optimizer/DataFlowAnalysis.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2019 IBM Corp. and others
* Copyright (c) 2000, 2022 IBM Corp. and others
*
* This program and the accompanying materials are made available under
* the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -853,6 +853,15 @@ class TR_Liveness : public TR_BackwardUnionBitVectorAnalysis
virtual Kind getKind();
virtual TR_Liveness *asLiveness();

/**
* @brief Perform a liveness analysis on the given \c TR_Structure
*
* @param[in] rootStructure : \c TR_Structure to perform a liveness analysis over
*
* @return none
*/
virtual void perform(TR_Structure *rootStructure) {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a Doxygen comment to this API? e.g.,

/**
 * @brief Perform a liveness analysis on the given \c TR_Structure
 * 
 * @param[in] rootStructure : \c TR_Structure to perform a liveness analysis over
 * 
 * @return none
 */

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I've added the comment.


bool traceLiveness() { return _traceLiveness; }


Expand Down