-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always define __MAP_64 #6989
Merged
Merged
Always define __MAP_64 #6989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8102104
to
d05ecf3
Compare
pshipton
reviewed
May 12, 2023
d230348
to
4b7f590
Compare
pshipton
approved these changes
May 12, 2023
keithc-ca
reviewed
May 15, 2023
Any more review comments ? |
keithc-ca
approved these changes
May 15, 2023
babsingh
requested changes
May 15, 2023
When OMRPORT_MMAP_FLAG_ZOS_64BIT is passed in, we set flag __MAP_64 on z/OS version 2.4 and up. Related to eclipse-openj9/openj9#17073 Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
Review comments addressed. |
jenkins build all |
Linux riscv64 machine (deb10-x64-1) is offline, and the riscv build is not impacted by these changes. |
babsingh
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
OMRPORT_MMAP_FLAG_ZOS_64BIT
is passed in, we set flag__MAP_64
on z/OS version 2.4 and up.Related to eclipse-openj9/openj9#17073