Clean up x86 supports_feature_test #7258
Open
+11
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to draft while I investigate the x86 macOS failures |
Some cases were missing the check that they returned the expected value. Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Spencer-Comin
force-pushed
the
x-supports
branch
from
ee1c24e
to
52c02b4
Compare
|
x86 macOS failure is #7181 |
|
@BradleyWood Can we get your review on this PR ? |
BradleyWood
approved these changes
Apr 8, 2024
|
@Spencer-Comin Wondering if this change is needed for OMR tests ? |
|
Jenkins build all |
|
@r30shah My port library changes in the tril tests rely on this change #7252 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supports_feature_testdid not check that the returnedsupports*()value matches the expected value, and instead directly return thesupports*()value.OMR_FEATURE_X86_FMAwas not included insupports_feature_test