Initialize port lib properly for tril tests #7252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spencer-Comin
requested review from
Leonardo2718,
fjeremic,
0xdaryl,
dsouzai,
charliegracie and
mstoodle
as code owners
|
@sarwat12 fyi |
Spencer-Comin
force-pushed
the
triltest-portlib
branch
8 times, most recently
from
9103885
to
d75a9a0
Compare
|
Relies on #7258 to not crash in OMR tests |
Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Spencer-Comin
force-pushed
the
triltest-portlib
branch
from
d75a9a0
to
07e1d2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global object
TR::Compiler->portLibwas defaulted to NULL, even though the tril tests initialize an OMR port libraryprivateOmrPortLibrary. This PR passesprivateOmrPortLibrarythrough to whereTR::Compileris initialized for tril tests.