Add compressbits and expandbits opcodes #7259
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relies on #7252 for TRIL tests to work correctly |
github-actions
bot
added
arch:aarch32
arch:aarch64
arch:power
arch:riscv
arch:x86
comp:compiler
labels
|
@r30shah fyi |
Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Signed-off-by: Bradley Wood <bradley.wood@ibm.com>
Signed-off-by: Spencer Comin <spencer.comin@ibm.com> Co-Authored-By: Bhavani <81695814+bhavanisn@users.noreply.github.com>
Uses pext and pdep intrinsics on x86 when supported. Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Spencer-Comin
force-pushed
the
compress-expand-opcodes
branch
from
e6854a6
to
bcf5ea4
Compare
Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Spencer-Comin
force-pushed
the
compress-expand-opcodes
branch
from
bcf5ea4
to
eb12ac0
Compare
|
Instruction selection log excerpts: Powerexpandbitscompressbitsx86expandbitscompressbits |
r30shah
suggested changes
Jun 7, 2024
| /* .reverseBranchOpCode = */ TR::BadILOp, \ | ||
| /* .booleanCompareOpCode = */ TR::BadILOp, \ | ||
| /* .ifCompareOpCode = */ TR::BadILOp, \ | ||
| /* .description = compress bits: equivalent to calling Integer.compress(a, b) */ |
There was a problem hiding this comment.
It seems bit ambiguous what Integer.compress(a,b) is looking at the change just with OMR perspective.
| @@ -11997,6 +11998,216 @@ TR::Node *sxorSimplifier(TR::Node * node, TR::Block * block, TR::Simplifier * s) | |||
| return node; | |||
| } | |||
|
|
|||
| template <typename T> | |||
There was a problem hiding this comment.
Can you add a high level description for this function in Comment? Also same for compressBits simplifier.
| { | ||
| T mask = maskChild->getConst<T>(); | ||
| if (srcChild->getOpCode().isLoadConst() && | ||
| performTransformation(s->comp(), "%sReduced %s of const src and const mask in node [%s] to const\n", |
There was a problem hiding this comment.
It may be more beneficial if someone tries to find out what transformed to print the node pointer (See other perform transformation usage).
| { | ||
| foldConstant<T>(node, expandBits(srcChild->getConst<T>(), maskChild->getConst<T>()), s, false); | ||
| } | ||
| else if (mask == static_cast<T>(0) && |
There was a problem hiding this comment.
Same comment as previous. Also please review and update further performTransformation messeges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lcompressbits,icompressbits,scompressbits,bcompressbitslexpandbits,iexpandbits,sexpandbits,bexpandbitsSee #7172