Implement new JDK12 method java.lang.String.indent(int) #4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharon-wang
force-pushed
the
indent-issue3850
branch
from
48b675b
to
8ceae92
Compare
pshipton
reviewed
Feb 16, 2019
|
you can change the pr description to include "Fixes: #3850" since this is the last change needed to finish the issue. I'll give this a first review. |
theresa-m
reviewed
Feb 16, 2019
test/functional/Java11andUp/src/org/openj9/test/java_lang/Test_String.java
Outdated
Show resolved
Hide resolved
test/functional/Java11andUp/src/org/openj9/test/java_lang/Test_String.java
Show resolved
Hide resolved
test/functional/Java11andUp/src/org/openj9/test/java_lang/Test_String.java
Outdated
Show resolved
Hide resolved
sharon-wang
force-pushed
the
indent-issue3850
branch
4 times, most recently
from
2e9a4f3
to
61312ce
Compare
theresa-m
approved these changes
Feb 20, 2019
There was a problem hiding this comment.
lgtm other than a small formatting change. @DanHeidinga or @pshipton can I ask one of you for a review?
Note this PR is dependent on the test framework commit in #4105 so that these tests can be moved to Java12andUp
sharon-wang
force-pushed
the
indent-issue3850
branch
2 times, most recently
from
7da0723
to
b08a715
Compare
sharon-wang
changed the title
DanHeidinga
reviewed
Feb 20, 2019
test/functional/Java11andUp/src/org/openj9/test/java_lang/Test_String.java
Outdated
Show resolved
Hide resolved
test/functional/Java11andUp/src/org/openj9/test/java_lang/Test_String.java
Outdated
Show resolved
Hide resolved
sharon-wang
force-pushed
the
indent-issue3850
branch
from
b08a715
to
ce992da
Compare
DanHeidinga
reviewed
Feb 21, 2019
sharon-wang
force-pushed
the
indent-issue3850
branch
7 times, most recently
from
1d294c2
to
79ea0f5
Compare
indent(int) adjusts the indentation of a string by adding or removing whitespace from the beginning of a string. Signed-off-by: Sharon Wang <sharon-wang-cpsc@outlook.com>
sharon-wang
force-pushed
the
indent-issue3850
branch
from
79ea0f5
to
b62b377
Compare
|
@DanHeidinga should be good to go! |
|
Jenkins test sanity xlinux jdk12 |
|
only build failure is the known |
|
Congrats @sharon-wang on your first OpenJ9 PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3850.
Dependent on: #4105 test framework commit - sanity test for indent(int) will be moved to Java12andUp once it is available.
Signed-off-by: Sharon Wang sharon-wang-cpsc@outlook.com