Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods and tests for jep334 String #4105

Merged
merged 3 commits into from Feb 22, 2019
Merged

Methods and tests for jep334 String #4105

merged 3 commits into from Feb 22, 2019

Conversation

theresa-m
Copy link
Contributor

@theresa-m theresa-m commented Dec 18, 2018 •
edited

  • Java12andUp test framework
  • String.describeConstable & tests
  • String.resolveConstantDesc & tests

Depends on (see #4195):

Signed-off-by: Theresa Mammarella Theresa.T.Mammarella@ibm.com

@theresa-m theresa-m force-pushed the jep334_string branch 2 times, most recently from b200994 to e916f2e Compare December 19, 2018 14:10
@theresa-m theresa-m mentioned this pull request Jan 8, 2019
Closed
9 tasks
@theresa-m theresa-m force-pushed the jep334_string branch 3 times, most recently from d35e2c0 to 750f3dc Compare January 28, 2019 15:11
@pshipton pshipton added this to the Release 0.13.0 (Java 12) milestone Jan 28, 2019
@pshipton pshipton added this to In progress in JEP 334 via automation Jan 28, 2019
@theresa-m theresa-m mentioned this pull request Jan 31, 2019
Closed
@pshipton
Copy link
Member

String implements Constable, ConstantDesc
http://cr.openjdk.java.net/~iris/se/12/build/latest/api/java.base/java/lang/String.html

@theresa-m
Copy link
Contributor Author

implements Constable, ConstantDesc is included here #4030

@theresa-m theresa-m force-pushed the jep334_string branch 2 times, most recently from 1b8f265 to 048174d Compare February 14, 2019 22:25
@theresa-m
Copy link
Contributor Author

theresa-m commented Feb 14, 2019 •
edited

I've updated the tests based on the review from @DanHeidinga

I've also added the commit from #4104 to this pr because adding an empty testng entry does not compile. fyi @smlambert

@theresa-m theresa-m mentioned this pull request Feb 14, 2019
Closed
DanHeidinga
DanHeidinga approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - @smlambert are you OK with the test-related changes?

@DanHeidinga
Copy link
Member

Jenkins test sanity zlinux jdk11

@smlambert
Copy link
Contributor

Jenkins test sanity zlinux jdk11

@smlambert
Copy link
Contributor

previous PR test failed with machine issue (remote call to node failed), retrying to see if transient

@DanHeidinga
Copy link
Member

Jenkins test sanity zlinux jdk12

@DanHeidinga DanHeidinga self-assigned this Feb 19, 2019
@JasonFengJ9 JasonFengJ9 mentioned this pull request Feb 20, 2019
Closed
@sharon-wang sharon-wang mentioned this pull request Feb 20, 2019
Merged
@DanHeidinga
Copy link
Member

@theresa-m Can you rebase this PR so it'll pick up the fix for the jvm interface version # issue?

@theresa-m
Methods for jep334 String
a67269e 
- String.describeConstable
- String.resolveConstantDesc

Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m
Setup for Java12andUp tests
c7f2227 
- including playlist.xml entry for jep334 tests

Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m
Tests for jep334 String
97e4578 
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m
Copy link
Contributor Author

yes. done

@DanHeidinga
Copy link
Member

Jenkins test sanity xlinux jdk12

@theresa-m theresa-m mentioned this pull request Feb 21, 2019
Merged
@DanHeidinga
Copy link
Member

Jenkins test sanity xlinux jdk12

@theresa-m
Copy link
Contributor Author

failing tests are related to #4661

@DanHeidinga
Copy link
Member

Build failures are in the com.ibm.j9.jsr292.api.MethodHandleAPI_defineClass.test_defineClass_ClassBytes_CorruptedArray test and unrelated to this PR

@DanHeidinga DanHeidinga merged commit 5cc3b1b into eclipse-openj9:master Feb 22, 2019
JEP 334 automation moved this from In progress to Done Feb 22, 2019
@theresa-m theresa-m deleted the jep334_string branch February 25, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@DanHeidinga DanHeidinga DanHeidinga approved these changes

Assignees

@DanHeidinga DanHeidinga

Labels
comp:test comp:vm jdk12
Projects
No open projects
JEP 334
  
Done
Milestone
Release 0.13.0 (Java 12)
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@theresa-m @pshipton @DanHeidinga @smlambert @fjeremic