Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set refc to VarHandle when creating a VarHandleInvokeHandle #7742

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

mikezhang1234567890
Copy link
Contributor

The referring class should be the VarHandle class instead of null.

Signed-off-by: Mike Zhang mike.h.zhang@ibm.com

Fixes #7172
since reference class won't be null anymore when creating a MethodHandle for the VarHandle and thus won't throw a NullPointerException in MethodHandles.checkSecurity.

The referring class should be the VarHandle class instead of null.

Signed-off-by: Mike Zhang <mike.h.zhang@ibm.com>
Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanHeidinga
Copy link
Member

Jenkins test sanity zlinux jdk11

@DanHeidinga DanHeidinga self-assigned this Nov 11, 2019
@DanHeidinga DanHeidinga merged commit ef7646f into eclipse-openj9:master Nov 14, 2019
M-Davies added a commit to M-Davies/openjdk-tests that referenced this pull request Nov 15, 2019
TestSecurityManagerChecks.java fixed in eclipse-openj9/openj9#7759. VarHandleTestReflection.java fixed in eclipse-openj9/openj9#7742
smlambert pushed a commit to adoptium/aqa-tests that referenced this pull request Nov 18, 2019
* Excludes for JDK8 and 13 openj9

* TestSecurityManagerChecks.java & VarHandleTestReflection.java fixed

TestSecurityManagerChecks.java fixed in eclipse-openj9/openj9#7759. VarHandleTestReflection.java fixed in eclipse-openj9/openj9#7742

* Updated exclude link for ProxyLayerTest.java
@mikezhang1234567890 mikezhang1234567890 deleted the mh_null_refc branch June 13, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JTReg Failure: java/lang/invoke/VarHandles/VarHandleTestReflection.java
2 participants