Skip getNestMembers security check for array/primitive/void #7759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanHeidinga
reviewed
Nov 13, 2019
Each of the Class objects representing array types, primitive types, and void returns an array containing only this, and there is no need to perform further security check in such cases. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
JasonFengJ9
force-pushed
the
nestmatesm
branch
from
c9ae168 to
a75f9f9
Compare
|
Jenkins test sanity zlinux jdk11 |
M-Davies
pushed a commit
to M-Davies/openjdk-tests
that referenced
this pull request
Nov 15, 2019
TestSecurityManagerChecks.java fixed in eclipse-openj9/openj9#7759. VarHandleTestReflection.java fixed in eclipse-openj9/openj9#7742
smlambert
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Nov 18, 2019
* Excludes for JDK8 and 13 openj9 * TestSecurityManagerChecks.java & VarHandleTestReflection.java fixed TestSecurityManagerChecks.java fixed in eclipse-openj9/openj9#7759. VarHandleTestReflection.java fixed in eclipse-openj9/openj9#7742 * Updated exclude link for ProxyLayerTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip getNestMembers security check for array/primitive/void
As per Java doc [1], each of the Class objects representing array types, primitive types, and void returns an array containing only this, and there is no need to perform further security check in such cases.
Verified that this PR fixes #7715
The JTReg test in question can serve the regression test purpose.
[1] https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Class.html#getNestMembers()
closes: #7715
Reviewer: @DanHeidinga
Signed-off-by: Jason Feng fengj@ca.ibm.com