Added custom headers support for WebSocket connection

[vit21ik]

#502

Minor fix that allow use custom headers in request using WebSockets :

Added new parameter "customHeaders" to MqttConnectOptions
Pass this param to WebSocketHandshake
Added new custom headers to handshake request
Please make sure that the following boxes are checked before submitting your Pull Request, thank you!

• [*] You have signed the Eclipse ECA
• [*] All of your commits have been signed-off with the correct email address (The same one that you used to sign the CLA)
• [*] If This PR fixes an issue, that you reference the issue below. OR if this is a new issue that you are fixing straight away that you add some Description about the bug and how this will fix it.
• If this is new functionality, You have added the appropriate Unit tests.

[vit21ik]

What going on?

The pull request did not pass Eclipse validation.
My profile - https://accounts.eclipse.org/users/vvlasiuk4xs

[jpwsutton]

Hi @vit21ik, Thanks for your contribution, it looks quite useful! I'll review your changes today, but you'll need to update your commit messages to include the Signed-off-by message with the email address used to sign the ECA: https://wiki.eclipse.org/ECA before we can accept them.

Thanks - James

[jpwsutton]

Would it be possible for you to move the example from the MQTTv3.md file into the project Wiki Please?

Also, in MqttConnectOptions, please could you rename customHeaders to customWebsocketHeaders along with the Getter and Setter. Other than that it looks good!

[davidgraeff]

Is there a reason to use the type Properties instead of a more generic Map<String,String>? Properties implement the very old and obsolete Dictionary interface and new code should not necessarily use it if no old java properties file is read.

[vit21ik]

I can see that Properties used for sslClientProps

 private Properties sslClientProps = null;

From the beginning I used Map, but changed to Properties for uniformity with existed sslClientProps.

[vit21ik]

1. Updated MQTTv3.md
2. Renamed customHeaders to customWebSocketHeaders
3. Added custom headers to mqtt v5

[jpwsutton]

Thanks for making the updates @vit21ik, please could you update your commit messages to include the Signed-off-by message with the email address used to sign the ECA: https://wiki.eclipse.org/ECA, Otherwise we won't be able to accept them.

[vit21ik]

Hi guys
I resolved merge conflict, but:

1. The Travis CI build failed - what is going on? looks after I merged develop to forked branch, build failed.
2. I updated my commit message - added: -author="Author Name v....k@gmail.com" (because usually I worked with another email by default). You can see that my icon on commits also changed. Anyway I see that "The following users do not have valid ECAs". Despite https://accounts.eclipse.org/users/vvlasiuk4xs/eca. Could someone help me with this?

[davidgraeff]

You should squash all commits into one and sign that. The IP validation doesn't look at only the last commit, but all commits have to be signed with the correct e-mail.

[vit21ik]

Created new pull request instead of this with correct Eclipse validation (sorry, I cannot manage with validation in current)
#554

[jpwsutton]

Closed as this was resolved in PR #554