Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Propertiest to Map for custom WebSocket Headers (502) #555

Merged
merged 2 commits into from
Aug 6, 2022

Conversation

vit21ik
Copy link
Contributor

@vit21ik vit21ik commented Jun 19, 2018

Signed-off-by: Vitalii vitalii.vlasiuk@temy.co

Please make sure that the following boxes are checked before submitting your Pull Request, thank you!

  • [* ] This change is against the develop branch, not master.
  • [* ] You have signed the Eclipse ECA
  • [* ] All of your commits have been signed-off with the correct email address (The same one that you used to sign the CLA) Hint: use the -s argument when committing.
  • [* ] If This PR fixes an issue, that you reference the issue below. OR if this is a new issue that you are fixing straight away that you add some Description about the bug and how this will fix it.
  • If this is new functionality, You have added the appropriate Unit tests.

Changed Properties to Map for Custom WebSocket Headers

Signed-off-by: Vitalii <vitalii.vlasiuk@temy.co>
@davidgraeff
Copy link

@jpwsutton Can this change be implemented? The old properties interface really makes no sense here and in Eclipse Smarthome the given Maps would require an unnecessary conversion.

@rdasgupt rdasgupt merged commit 188aa66 into eclipse:develop Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants