Error Stack fix #212
Open
Error Stack fix #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In browsers when localStorage access is disabled for your domain the browsers will throw an Access denied error if you try to even read the localStorage property. This commit adds try/catch logic to handle the error and use the in-memory fallback. Signed-off-by: Matt Cowan <mcowan@atlassian.com>
Signed-off-by: Mark Evans <mark.evans2@sky.uk>
…ments Signed-off-by: Mark Evans <mark.evans2@sky.uk>
Handle cases where localStorage access is denied
…websocket No implicit global WebSocket
Also-by: Piotr Kuczynski <piotr.kuczynski@gmail.com>
Signed-off-by: Lleonard Subirana <arsu.leo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing for stack on errors, the statements were reversed.
For instance, if user code throws an exception, it states "No Error Stack Available" on the error making it quite difficult to debug.
Furthermore, if client browser's Errors would not have the stack field, the fixed statements would throw an exception.