Support browser usage in strict mode #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when passing `this` inside the scope setup function in a browser leads to a `Cannot set property Paho of undefined` error. To address this we wrap up the initialization logic in another scoped IIFE that sets up a commonjsGlobal variable with appropriate fallback. We can then use this variable instead of the undefined `this` when we attempt to export the Paho library. Signed-off-by: Matt Cowan <mcowan@atlassian.com>
|
It is easiest to view the diff with whitespace changes hidden, since a lot of indenting happened: https://github.com/eclipse/paho.mqtt.javascript/pull/190/files?utf8=%E2%9C%93&diff=unified&w=1 I'm struggling to understand the test failures, so I can certainly use a hand there. |
|
The build failure was general, due to package dependencies needing updating. I've merged these changes into the develop branch, and the build & tests worked: https://travis-ci.org/eclipse/paho.mqtt.javascript/builds/541371747 The auto-merging didn't work, but I think I got the manual resolution correct. Let me know if there's any issue. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when passing
thisinside the scope setup function in abrowser leads to a
Cannot set property Paho of undefinederror.To address this we wrap up the initialization logic in another scoped
IIFE that sets up a commonjsGlobal variable with appropriate fallback.
We can then use this variable instead of the undefined
thiswhen weattempt to export the Paho library.
Signed-off-by: Matt Cowan mcowan@atlassian.com