Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait implementations are rewritten without SWTBot depedencies #94

Closed
wants to merge 1 commit into from

Conversation

vpakan
Copy link
Contributor

@vpakan vpakan commented Jul 31, 2013

WaitWhile and WaitUntil should not use SWTBot API

@ghost ghost assigned rawagner Mar 28, 2013
@ghost ghost assigned vpakan Jul 30, 2013
@vpakan vpakan mentioned this pull request Jul 31, 2013
@jboss-reddeer
Copy link
Contributor

ProjectItemTests are failing (see RedDeer_verification/33/), please fix.

@vpakan
Copy link
Contributor

vpakan commented Aug 1, 2013

Tests are fixed and passing locally

@jpeterka
Copy link
Contributor Author

jpeterka commented Aug 1, 2013

reviewing this one

@jpeterka
Copy link
Contributor Author

jpeterka commented Aug 1, 2013

please fix WaitWhile block formatting

@jpeterka
Copy link
Contributor Author

jpeterka commented Aug 1, 2013

and add missing javadoc for classes you update

Adds possibility to not throw Exception in case
Wait was not successful
@vpakan
Copy link
Contributor

vpakan commented Aug 1, 2013

javadoc added

@jpeterka
Copy link
Contributor Author

jpeterka commented Aug 1, 2013

thx, pushed to master

@jpeterka jpeterka closed this Aug 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants