Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update test projects and build references #1200

Merged
merged 7 commits into from
Apr 29, 2021

Conversation

andre15silva
Copy link
Contributor

Waiting for project moves from #1195

@andre15silva andre15silva force-pushed the move-tests branch 2 times, most recently from b92a9a9 to e041ab3 Compare March 24, 2021 10:35
@andre15silva
Copy link
Contributor Author

maven.inria.fr is down, CI failing because of that

@monperrus
Copy link
Contributor

maven.inria.fr is down, CI failing because of that

Seems up again. But I don't find a way to restart failing builds on https://ci.eclipse.org/repairnator/job/repairnator-ci/. @javierron any idea?

@javierron
Copy link
Contributor

@monperrus I've restarted the failing builds on all pull requests

@javierron
Copy link
Contributor

Hey @andre15silva, I want to rebase these changes into my PR #1215. What's left to do here?

@andre15silva
Copy link
Contributor Author

andre15silva commented Apr 26, 2021

I'm waiting for the projects mentioned in #1195 to be moved. When that is done, it's a matter of changing the references in the tests (maybe some builds need to be triggered again too). @javierron

@monperrus
Copy link
Contributor

@andre15silva do we need to move all projects or can we proceed as is, with the ones which have already been moved?

if we can proceed, we would unwip and merge this one, and @javierron would rebase #1195 afterwards.

WDYT?

@andre15silva
Copy link
Contributor Author

Yes, we can merge as is and leave the rest of the changes pending.

I'll rebase this PR and mark it ready.

@monperrus
Copy link
Contributor

I'll rebase this PR and mark it ready.

perfect, and @javierron will merge it afterwards

@andre15silva andre15silva marked this pull request as ready for review April 26, 2021 13:21
@andre15silva andre15silva changed the title WIP: move test projects and builds to repairnator org move test projects and builds to repairnator org Apr 26, 2021
Signed-off-by: André Silva <andre15andre@hotmail.com>
@andre15silva
Copy link
Contributor Author

@javierron do you know what might be causing the build failure in repairnator-runtime?

The first build failed with test cases returning 404 errors, and the two others timed-out.

@javierron
Copy link
Contributor

I've fixed those 404s in my PR, the timeouts might be related. I will cherry-pick my commit to this branch to see if we can get the tests passing.

Signed-off-by: Javier Ron <javierron90@gmail.com>
@javierron
Copy link
Contributor

javierron commented Apr 26, 2021

@andre15silva I fixed the repairnator-realtime 404s, however there are a some more in repairnator-pipeline.

It seems like travis-ci.org is removing old builds that our tests depend on (example).

I think the best solution is to create our own builds (maybe in repairnator/failingProject ?) that fulfill the tests' requirements.

@andre15silva
Copy link
Contributor Author

andre15silva commented Apr 27, 2021

I think the best solution is to create our own builds (maybe in repairnator/failingProject ?) that fulfill the tests' requirements.

I think so too. I'm doing that change and adding it to this PR. Thanks!

Signed-off-by: André Silva <andre15andre@hotmail.com>
Signed-off-by: André Silva <andre15andre@hotmail.com>
Signed-off-by: André Silva <andre15andre@hotmail.com>
Signed-off-by: André Silva <andre15andre@hotmail.com>
@andre15silva
Copy link
Contributor Author

@javierron There are two issues right now:

  • I'm not being able to get TestComputePlugins with the new branch I created for this test in https://github.com/repairnator/failingProject/tree/plugins. It doesn't detect the plugin.
  • There are two test cases in TestCheckoutBuild that depend on two builds I'm not being able to reproduce.
    • The first, testCheckoutBuildFromPRWithMissingMerge, tests a build with merge conflicts, but Travis doesn't run the builds for those anymore as far as I understood.
    • The second, testCheckoutBuildFromPROtherRepo, tries to checkout a build of a PR from another repo and fails, but the builds I've created don't fail.

WDYT we should do with these? The latter issue doesn't affect (currently) the tests, as the builds are still available. The first one needs a change tho.

@javierron
Copy link
Contributor

@andre15silva I believe the plugins in the test project should be outside the <pluginManagment> key. I'm not 100% sure but the pom structure we are trying to recreate was this one. I would have changed it right now but I don't have push access to repairnator/failingProject 🙃

Signed-off-by: André Silva <andre15andre@hotmail.com>
@andre15silva
Copy link
Contributor Author

@andre15silva I believe the plugins in the test project should be outside the <pluginManagment> key. I'm not 100% sure but the pom structure we are trying to recreate was this one.

It was that indeed. Fixed! Thanks!

I would have changed it right now but I don't have push access to repairnator/failingProject upside_down_face

I don't have the permission to add you, needs to be @monperrus

@javierron
Copy link
Contributor

Thanks @andre15silva! We're finally green again. 🚀

Since this is blocking our other PRs, let's merge these changes and take care of the 2 remaining builds in a separate PR.

@javierron javierron changed the title move test projects and builds to repairnator org refactor: update test projects and build references Apr 29, 2021
@javierron javierron merged commit 75ed5ae into eclipse:master Apr 29, 2021
@monperrus
Copy link
Contributor

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants