Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWT Chart Should Use Internationalization #97

Closed
fbuloup opened this issue Jan 7, 2020 · 3 comments
Closed

SWT Chart Should Use Internationalization #97

fbuloup opened this issue Jan 7, 2020 · 3 comments

Comments

@fbuloup
Copy link
Contributor

fbuloup commented Jan 7, 2020

SWT Chart plugins should use Internationalization.

I will provide a PR to propose changes in order to implement these changes
fbuloup added a commit to fbuloup/swtchart that referenced this issue Jan 7, 2020
@fbuloup
Fix issue eclipse#97
79f8f85 
Signed-off-by: frank buloup <frank.buloup@univ-amu.fr>
@eselmeister
Copy link
Contributor

I have added a comment.
Otherwise it looks good.

@laeubi Do you have any comments?

@laeubi
Copy link
Member

laeubi commented Jan 8, 2020

I wonder if there are more labels that needs translation.

@fbuloup
Copy link
Contributor Author

fbuloup commented Jan 8, 2020

Yes there are : other menu items and some message on dialog box.
I will try to do a commit before tomorow

fbuloup added a commit to fbuloup/swtchart that referenced this issue Jan 9, 2020
@fbuloup
Fix eclipse#97
ab7f26e 
Initial swtchart internationalization

Signed-off-by: frank buloup <frank.buloup@univ-amu.fr>
eselmeister added a commit that referenced this issue Jan 11, 2020
@eselmeister
Merge pull request #98 from fbuloup/issue_97
a03bba0 
Fix issue #97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eselmeister @laeubi @fbuloup