Add TextMate Language Pack feature #374
Conversation
Syntax highlighting and more for programming languages and file formats by taken TextMate grammars and language configurations files from the Visual Studio Code project (<https://github.com/microsoft/vscode/tree/main/extensions>). For details which file is taken from where see "org.eclipse.tm4e.language_pack/about.md". The content is created and can be updated via the Maven build script "/org.eclipse.tm4e.language_pack/_update/pom.xml".
|
@howlger thanks! |
|
Could you add a testcase that verifies that all syntax files are actually parseable by tm4e? I sometimes have the problem that 3rd party syntax files cannot be loaded, e.g. because of usage of unsupported regex expressions etc., e.g. tamasfe/taplo#245 and if we want to provide a default language package we should ensure that all files contained actually work. |
It's really entirely about the license. If the license permits us to grab the content in use it in the manner that we intend to use it, then it is allowed.
Follow the normal process. For the time being, this means create a project code contribution CQ and the IP Team will review the content for you. When you do create the CQ, please let the IP Team know that I've already had a look and have some insight to share. The short version is that I ran the entire The bat : MIT |
OK, we have https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/2399 opened for VSCode (all of it!) already. So should we just wait for completion of those CQs? |
This sounds like a good idea, and I hope someone else is able to do it. 😉 I tested all languages manually with an example file I created myself. The languages that didn't work for me are commented out in the I cannot reproduce the issue of the given example. To my understanding this should not be an issue with Java 8 or higher (see Baeldung: "Up until Java 8, we might run into the limitation that unbound quantifiers, like + and *, are not allowed within a lookbehind assertion."). But |
|
@waynebeaton Thanks for the reply. Your explanation and the ScanCode license categories makes it a bit clearer to me. Should the I guess the feature copyright note has also to be changed for the files not under the EPL, right? Could you please provide a wording for this or point me to an example? What's about |
|
iP ticket approved. We''ll proceed with the merge soon. |
Every plug-in should have an
Leave the feature copyright and license statement as is. I'm thinking that the easiest way to account for the licenses is to drop a list/table based on the list I generated above into the
Yes, they need to be checked. Basically, it's scancode's way of saying something to the effect of "I found a license, but I don't know what it is". We've since tuned our tools that interpret the scancode results to ignore AFAICT, the |
The "IP ticket" that you're referring to is for the review of third party content. This appears to be a significant contribution of project code, much of which is forked from third party sources. What I told you to do was this:
|
|
Thanks @mickaelistria and thanks @waynebeaton for the helpful explanation. @mickaelistria, I will change the |
|
IP approved! |
Syntax highlighting and more for programming languages and file formats by taken TextMate grammars and language configurations files from the Visual Studio Code project.
I don't know whether it is allowed and legal to take files from the Visual Studio Code project in this way, and if so, what information has to be provided and where. Could this please be checked by intellectual property experts? For details which files are taken from where, see below.
The content is created and can be updated via the Maven build script
org.eclipse.tm4e.language_pack/_update/pom.xml.Some languages have been commented out due to issues.
See also my Language Pack for Eclipse project.
List of files taken from Visual Studio Code
The following TextMate grammar and language configuration files have been taken and slightly modified from the
Visual Studio Code's built-in extensions.
Most of the grammar files were in turn converted by the Visual Studio Code project from other projects (see column Original).