Fix indentation problem with onEnterRule #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: azerr <azerr@redhat.com>
|
I did that very quickly and it requires some write of tests, but it should fix eclipse-wildwebdeveloper/wildwebdeveloper#599 See the following demo:
|
|
I would be fine merging it even without tests if it was tested manually. |
If you think the behavior is good, feel free to merge it, but I cannot promise you that it will provide some troubles. We need to write tests (and perhaps there are some vscode tests that we should translate for tm4e). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix indentation problem with onEnterRule
Signed-off-by: azerr azerr@redhat.com