Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax colouring when inline comments contain multi-byte characters + numerical constants/punctuation #451

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Fix syntax colouring when inline comments contain multi-byte characters + numerical constants/punctuation #451

merged 1 commit into from
Oct 12, 2022

Commits on Oct 12, 2022

  1. Fix finding end of the regexp in multi-byte string 

    Fix finding the end of the regexp in a multi-byte string and incorrect use of bytesCount instead of the string length in multi-byte characters. In C/C++ grammars the bug is triggered by strings/comments containing multi-byte characters and numeric constants/punctuation.
Additional comment: lineTokens.produce() takes length of the string in multi-byte characters as a second parameter and captureIndices of OnigCaptureIndex are also counted as characters (see OnigNextMatchResult.captureIndicesOfMatch()).
    @shapayev
    shapayev committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    782ea94 View commit details
    Browse the repository at this point in the history