Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: On enter rule don't use the proper insert spaces / tab width when those settings are changed #517

Merged
merged 1 commit into from
Apr 4, 2023
Merged

fix: On enter rule don't use the proper insert spaces / tab width when those settings are changed #517

merged 1 commit into from
Apr 4, 2023

Conversation

angelozerr
Copy link
Contributor

fix: On enter rule don't use the proper insert spaces / tab width when those settings are changed

Fixes #460

Signed-off-by: azerr azerr@redhat.com

@angelozerr angelozerr mentioned this pull request Apr 3, 2023
Closed
@angelozerr angelozerr force-pushed the spaces-fix-on-enter-rule2 branch 2 times, most recently from f10cb2a to ae72948 Compare April 3, 2023 13:15
@github-actions github-actions bot added the bug label Apr 3, 2023
@mickaelistria
Copy link
Contributor

This seems to require a version bump.

@angelozerr
Copy link
Contributor Author

@sebthom if I understand I need to update only the languageconfiguration plugin to 0.5.4.qualifier is that?

@sebthom
Copy link
Member

sebthom commented Apr 3, 2023

Yes, you should only need to bump the version of the plugins you are touching.

@angelozerr
Copy link
Contributor Author

Yes, you should only need to bump the version of the plugins you are touching.

Thanks @sebthom for your clarification.

@mickaelistria I pushed a new commit with bump,let's see if CI build will work now.

fix: On enter rule don't use the proper insert spaces / tab width when
0ec295a 
those settings are changed

Fixes eclipse#460

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor Author

@mickaelistria @sebthom it should be good now.

@mickaelistria mickaelistria merged commit 84c448f into eclipse:main Apr 4, 2023
@mickaelistria
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On enter rule don't use the proper insert spaces / tab width when those settings are changed
3 participants
@angelozerr @mickaelistria @sebthom