fix: minor bugfix to ToggleLineCommentHandler. #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewL-avlq
force-pushed
the
ToggleLineComment
branch
from
3cabbb8
to
dff909c
Compare
andrewL-avlq
changed the title
|
Can you please rework the commit message to be more explicit about the actual bug this fixes? |
As written, the removeLineComments() algorithm expects the commented lines to be processed in order, otherwise the document can become corrupted as the wrong characters get removed. This fix ensures that the lines are processed in order.
andrewL-avlq
force-pushed
the
ToggleLineComment
branch
from
dff909c
to
8cec6c3
Compare
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix removeLineComments() to ensure that lines are processed in order.