fix: handle grammar registrations to the same scope by different plugins #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change grammar registrations from different plugins sharing the same scope name could unpredictably overwrite each other. With this change, grammars are registered using fully qualified scope names (scopeName + '@' + pluginId). If plugin A supplies a content-type-to-scope and registers a grammar to that scope, it is ensured that if another plugin B also registers a grammar using the same scope, there won't be accidental usage of the plugin B's grammar via plugin A's content-type-to-scope binding. The change also makes multiple grammar registrations for the same scope visible in the Preferences>TextMate>Grammars table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change grammar registrations from different plugins sharing the same scope name could unpredictably overwrite each other.
With this change, grammars are registered using fully qualified scope names (scopeName + '@' + pluginId). If plugin A supplies a content-type-to-scope and registers a grammar to that scope, it is ensured that if another plugin B also registers a grammar using the same scope, there won't be accidental usage of the plugin B's grammar via plugin A's content-type-to-scope binding.
The change also makes multiple grammar registrations for the same scope visible in the Preferences>TextMate>Grammars table.