Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace owner usernames are not sorted #2191

Closed
ghost opened this issue Dec 23, 2019 · 4 comments
Closed

Namespace owner usernames are not sorted #2191

ghost opened this issue Dec 23, 2019 · 4 comments
Projects
0.13 (E01.19)
Milestone
0.13

Comments

@ghost
Copy link

ghost commented Dec 23, 2019

This is at best a marginally cosmetic issue.

In the manage section, the owners of a given namespace are listed, but not sorted (e.g. alphabetically or lexicographically).

For a namespace with enough owners, this can be a little ugly.

E.g.:
Screenshot from 2019-12-23 14-36-02
ghost pushed a commit to bosch-io/vorto that referenced this issue Jan 8, 2020
@menajrl
eclipse#2191
84ca138 
* Sorting user names in namespace owner table (2nd column)
* Added min and max height to column, with an overflow-y to scroll so large lists are limited in height and allow scrolling through

Signed-off-by: Menahem Julien Raccah Lisei <menahemjulien.raccahlisei@bosch-si.com>
@ghost
Copy link
Author

ghost commented Jan 8, 2020

PR here.

@ghost
Copy link
Author

ghost commented Jan 8, 2020

And looking like this now:

better

kolotu added a commit that referenced this issue Jan 13, 2020
@kolotu
Merge pull request #2200 from bosch-io/bug/2191_Namespace_owner_usern…
5d04d49 
…ames_are_not_sorted

#2191
@kolotu kolotu added this to the 0.13 milestone Jan 14, 2020
@kolotu kolotu added this to In Progress in 0.13 (E01.19) Jan 14, 2020
@kolotu kolotu assigned ghost Jan 14, 2020
@kolotu kolotu moved this from In Progress to Done in 0.13 (E01.19) Jan 14, 2020
@kolotu
Copy link
Member

kolotu commented Jan 14, 2020

@mena-bosch this issue is complete with your merged PR, right?

@kolotu kolotu closed this as completed Jan 14, 2020
@ghost
Copy link
Author

ghost commented Jan 14, 2020

@mena-bosch this issue is complete with your merged PR, right?

Indeed, thanks.

JulianFeinauer pushed a commit to JulianFeinauer/vorto that referenced this issue Jun 27, 2020
@menajrl @JulianFeinauer
eclipse#2191
eb665c6 
* Sorting user names in namespace owner table (2nd column)
* Added min and max height to column, with an overflow-y to scroll so large lists are limited in height and allow scrolling through

Signed-off-by: Menahem Julien Raccah Lisei <menahemjulien.raccahlisei@bosch-si.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
0.13 (E01.19)
  
Done
Milestone
0.13
Development

No branches or pull requests
1 participant
@kolotu