Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 0.13 migration SQL scripts remove redundant column "authentication_provider" if it exists #2219

Closed
ghost opened this issue Jan 13, 2020 · 1 comment
Closed

Make 0.13 migration SQL scripts remove redundant column "authentication_provider" if it exists #2219

ghost opened this issue Jan 13, 2020 · 1 comment
Labels
Repository
Projects
0.13 (E01.19)
Milestone
0.13

Comments

@ghost
Copy link

ghost commented Jan 13, 2020

This is a small add-on related to the migration guide for 0.13 (see mainly #2159).

On top of what they are already doing (creating required columns and setting up default values) the scripts should also clean up columns that might have been previously created in error, such as "authentication_provider" (we are using "authentication_provider_id" now).
ghost pushed a commit to bosch-io/vorto that referenced this issue Jan 13, 2020
@menajrl
eclipse#2219
68427a7 
* both SQL migration scripts now drop the authentication_provider redundant column conditionally

Signed-off-by: Menahem Julien Raccah Lisei <menahemjulien.raccahlisei@bosch-si.com>
@kolotu kolotu assigned ghost Jan 14, 2020
@kolotu kolotu added this to the 0.13 milestone Jan 14, 2020
@kolotu kolotu added this to In Progress in 0.13 (E01.19) Jan 14, 2020
@ghost
Copy link
Author

ghost commented Jan 14, 2020

#2220 merged. Closing.

@ghost ghost closed this as completed Jan 14, 2020
@kolotu kolotu moved this from In Progress to Done in 0.13 (E01.19) Jan 14, 2020
JulianFeinauer pushed a commit to JulianFeinauer/vorto that referenced this issue Jun 27, 2020
@menajrl @JulianFeinauer
eclipse#2219
bc3880b 
* both SQL migration scripts now drop the authentication_provider redundant column conditionally

Signed-off-by: Menahem Julien Raccah Lisei <menahemjulien.raccahlisei@bosch-si.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Repository
Projects
No open projects
0.13 (E01.19)
  
Done
Milestone
0.13
Development

No branches or pull requests
1 participant
@kolotu