Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple meanings of "multiple" keyword #990

Open
e-grigorov opened this issue Jun 28, 2018 · 3 comments
Open

Multiple meanings of "multiple" keyword #990

e-grigorov opened this issue Jun 28, 2018 · 3 comments
Labels

Comments

@e-grigorov
Copy link
Contributor

I just realized that I am mapping semantically different data containers with the same keyword - multiple. For example:

  • Java array
  • java.util.Collection
  • java.util.List
  • java.util.Set

What is the correct mapping from your point of view?

@aedelmann
Copy link
Contributor

Hi @e-grigorov
You are right, the DSL does not make any separation between these different container types.What would speak against putting this information into the mapping model for the device ?
I can imagine that there is a Functional Item Mapping file , that maps the (abstract) FB to the platform-specific Functional Item platform.

@e-grigorov
Copy link
Contributor Author

The mapping file is a platform/generator specific and it's possible to cover almost everything. To me, the question is: is it a platform specific feature? Does it mean that the pure Java generator has to do the same?

@aedelmann
Copy link
Contributor

aedelmann commented Oct 30, 2018

From the Vorto modelling perspective, I wouldnt necessarily care if a multiple property is of type collection or array. This is implementation/platform specific. In the platform, I would need this information in order to process the device data correctly. The platform mapping, e.g. FunctionalItems would map this concrete to FI Basic types. The FI Generator would use this information and generate the Java source code.

Does it mean that the pure Java generator has to do the same?
If the Java Generator belongs to the same platform, then yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants