Make content in event and operation blocks required. Fixes #2058 #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kolotu <kevin.olotu@bosch-si.com>
|
Build is failing due to some test case failure with your change. Can u take a look ? |
|
Yes already on it. One of the test cases checks a model that's now invalid. I'll remove the empty operations block from the affected test case and re-run the test. |
… longer valid. Fixes eclipse#2058 Signed-off-by: kolotu <kevin.olotu@bosch-si.com>
|
The second commit should fix the integration tests. I've also manually tested the OpenAPI, Ditto and Hono generators locally with a model containing empty events and operations blocks - the output looks good to me. |
aedelmann
deleted the
2058-require_content_in_event_and_operation_blocks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes at least one element in the events{} and operations{} blocks required. Users will still be able to load models that have been created with empty blocks before this change, however they cannot be saved with empty blocks again.
Signed-off-by: kolotu kevin.olotu@bosch-si.com