Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2104 Ditto structure generation #2109

Conversation

kolotu
Copy link
Member

@kolotu kolotu commented Nov 26, 2019

Moved Ditto structure generation into EclipseDittoGenerator.

kolotu added 3 commits November 22, 2019 11:33
Signed-off-by: kolotu <kevin.olotu@bosch-si.com>
…est parameter. Fixes eclipse#2104

Signed-off-by: kolotu <kevin.olotu@bosch-si.com>
@aedelmann
Copy link
Contributor

Hi @kolotu
The tests are failing. It seems an encoding problem for different OS (windows, linux). You can check the other test cases how to verify the generated templates on different environments.

kolotu added 4 commits November 26, 2019 13:39
Signed-off-by: kolotu <kevin.olotu@bosch-si.com>
Signed-off-by: kolotu <kevin.olotu@bosch-si.com>
Signed-off-by: kolotu <kevin.olotu@bosch-si.com>
Signed-off-by: kolotu <kevin.olotu@bosch-si.com>
@kolotu
Copy link
Member Author

kolotu commented Nov 27, 2019

Due to the refactoring in the BoschIotSuiteGenerator, the whitespaces and indentations have changed a bit, so I have adapted the test to ignore differences in whitespacing.

Signed-off-by: kolotu <kevin.olotu@bosch-si.com>
@kolotu
Copy link
Member Author

kolotu commented Nov 27, 2019

Request header renamed to thingJson, Documentation URL changed to Ditto Generator readme.md (master)

Signed-off-by: kolotu <kevin.olotu@bosch-si.com>
@kolotu
Copy link
Member Author

kolotu commented Nov 27, 2019

Added thingJson parameter to Readme.md

@aedelmann aedelmann merged commit c8d183e into eclipse:development Nov 27, 2019
@aedelmann aedelmann deleted the 2104_implement_things_generation_and_caching branch November 27, 2019 07:08
JulianFeinauer pushed a commit to JulianFeinauer/vorto that referenced this pull request Jun 27, 2020
* Fixed URL building for generators. Fixes eclipse#2104

Signed-off-by: kolotu <kevin.olotu@bosch-si.com>

* Move Ditto structure creation into EclipseDittoGenerator and add request parameter. Fixes eclipse#2104

Signed-off-by: kolotu <kevin.olotu@bosch-si.com>

* Rename dittoStructure to dittoThingStructure. Fixes eclipse#2104

Signed-off-by: kolotu <kevin.olotu@bosch-si.com>

* Fix imports of generated classes. Fixes eclipse#2104

Signed-off-by: kolotu <kevin.olotu@bosch-si.com>

* Fix whitespaces to get tests passing again. Fixes eclipse#2104

Signed-off-by: kolotu <kevin.olotu@bosch-si.com>

* adapt request parameter in unit test. Fixes eclipse#2104

Signed-off-by: kolotu <kevin.olotu@bosch-si.com>

* Change request header for Ditto Generator

Signed-off-by: kolotu <kevin.olotu@bosch-si.com>

* Add thingJson parameter to readme. Fixes eclipse#2104

Signed-off-by: kolotu <kevin.olotu@bosch-si.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants