-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Chrome debugger #230
Comments
@AObuchow, I'm answering here the questions/comments you made on internal Slack
One possibility is that when you get it working with vscode, you run some |
It seems like we should instead use https://github.com/microsoft/vscode-chrome-debug/blob/master/src/chromeDebugAdapter.ts (so include the vscode-chrome-debug module) |
I didn't have much luck grepping for node but using the extension with VSCode and running It seems that the entry point might be chromeDebug.js rather than the adapter class. When running it with node, the process stays running/doesn't exit immediately. I'm going to experiement further with it. |
Update: I just got Chrome to launch from Eclipse using chromeDebug.js :) |
Great @AObuchow . |
Main patch in this story is merged. However I see that the Chrome Debug shortcut on right click starts a node.js debugger. |
Yes you're right. I just did a local rebase of my refactoring branch and the issue seems to be fixed there. Going to submit a PR now. |
Signed-off-by: Mickael Istria <mistria@redhat.com>
Refactoring was merged and includes all the fix. The Chrome Debugger seems usable enough now. Thanks @AObuchow ! |
My pleasure :)! |
I'm going to start working on integrating the chrome debugger as the vscode extension for it has a debuger adapter which is very similar to the node debugger's adapter.
The text was updated successfully, but these errors were encountered: