Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 340_lsp_support.md #26

Merged
merged 47 commits into from
Jul 8, 2024
Merged

Update 340_lsp_support.md #26

merged 47 commits into from
Jul 8, 2024

Conversation

crapo
Copy link
Contributor

@crapo crapo commented Nov 30, 2023

Added brief instructions on how to add TextMate grammar.

@crapo
Update 340_lsp_support.md
6d12e64 
Added brief instructions on how to add TextMate grammar.
@cdietrich
Copy link
Member

@crapo would be so kind an check if you still have a valid eca signed? https://www.eclipse.org/legal/ECA.php

cdietrich
cdietrich reviewed Dec 4, 2023
View reviewed changes
xtext-website/documentation/340_lsp_support.md Outdated
@@ -72,7 +72,10 @@ Xtext supports the generation of language servers that comply to the [Language S
"uuid": "8383e49a-fa0d-4bb5-827b-10e8abb294ca"
}
```
1. Open a `*.dmodel` file with the Generic Editor and explore the supported language features like syntax highlighting, content assist, validation, displaying code lenses, quickfixes, formatting, ... :
You may save the content in a file and then add it to the TextMate grammar in Preferences.
![image](https://github.com/eclipse/xtext-website/assets/1186278/63b7eae9-6f9e-485c-bcb5-a052acce077c)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assume we need a relative path here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how it will be rendered on the webpage once it is merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wont help inside eclipse help system i assume

@crapo
Copy link
Contributor Author

crapo commented Dec 4, 2023

I've completed an ECA.

cdietrich and others added 16 commits January 18, 2024 05:58
@cdietrich
Merge pull request eclipse#29 from eclipse/published
5784118 
Published -> Main
@cdietrich
Merge pull request eclipse#30 from eclipse/published
469b85a 
Published -> Main
@cdietrich
Revert "Revert "Revert "Revert "prepare 2.34 docs see eclipse/xtext#2845
af2a57c 
""""

This reverts commit bd80cf4.
@cdietrich
fix typo on main
e4dee80 
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
@cdietrich
Merge branch 'main' into merge_resolve
79ae3b5
@cdietrich
Merge pull request eclipse#31 from eclipse/merge_resolve
eb726fd 
fix typo
@cdietrich
finalize release notes
8846178 
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
@LorenzoBettini
Prepare Xtext/Xtend 2.35 release notes
d9061ca
@LorenzoBettini
updated release date and published property
bf842f8
@LorenzoBettini
Merge pull request eclipse#33 from eclipse/lb_2948
421e2f8 
Prepare Xtext/Xtend 2.35 release notes
@miklossy
Add "Testing" section to the Xtext 2.35.0 release notes.
d7ef7a2 
Signed-off-by: miklossy <miklossy@itemis.de>
@cdietrich
Merge pull request eclipse#34 from eclipse/add_testing_section_to_the…
24c0997 
…_release-notes

Add "Testing" section to the Xtext 2.35.0 release notes.
@miklossy @LorenzoBettini
Rename release notes files from "...2-35.md" to "...2.35-0.md".
ef78147 
Signed-off-by: miklossy <miklossy@itemis.de>
@LorenzoBettini
Normalization of EOLs in Xbase multi-line strings
26fb035
@LorenzoBettini @szarnekow
Update xtext-website/_posts/releasenotes/2024-05-28-version-2-35-0.md
b6bcb1f 
Co-authored-by: Sebastian Zarnekow <Sebastian.Zarnekow@gmail.com>
@LorenzoBettini
Update 2024-05-28-version-2-35-0.md
69ae3f3
@LorenzoBettini
Copy link
Contributor

@cdietrich can we merge this one?

@LorenzoBettini
Merge pull request eclipse#38 from eclipse/lb_36
9f70454 
Normalization of EOLs in Xbase multi-line strings
@cdietrich
Copy link
Member

My question is not answered

@LorenzoBettini
Copy link
Contributor

which one?

@cdietrich
Copy link
Member

If it works in eclipse help
Don’t have a machine with me where I have the ruby stuff set up.

@LorenzoBettini
Copy link
Contributor

@crapo maybe it's better if you put the PNG image in the images directory like we did for other images

LorenzoBettini and others added 22 commits May 24, 2024 13:06
@LorenzoBettini
future removal notice
00bd332
@LorenzoBettini
Result.assertNoErrors()/assertNoIssues()
bf4b917
@LorenzoBettini
The generated InjectorProvider
9d72688
@LorenzoBettini
renamed section
719d76b
@LorenzoBettini
.trace files
2d9b55c
@LorenzoBettini
initial support for Java 21
73188f2
@LorenzoBettini
JvmGenericTypeValidator
8e6a81d
@LorenzoBettini
writeStorageResources
7759af3
@LorenzoBettini
typo
2b66203
@LorenzoBettini
JvmGenericTypeValidator documented in Xbase documentation
267d1be
@LorenzoBettini
upgrades
0a09a19
@LorenzoBettini
Merge pull request eclipse#47 from eclipse/lb_n_and_n
81cdfd9 
Some N&N related to my chances and others' changes
@LorenzoBettini
another notice about Java 21
b327fb3
@LorenzoBettini
added credits
b1dca70
@LorenzoBettini
Merge pull request eclipse#48 from eclipse/LorenzoBettini-patch-1
7abc619 
some small changes, in particular, added credits
@szarnekow
New and Noteworthy for Xbase LSP and Unloadable Node model
a2bb918
@LorenzoBettini
published: true
4e7c30c
@LorenzoBettini
preparation for 2.36.
fa5e87b 
Including the removal of old testing projects
@LorenzoBettini
bump doc versions for 2.36
5770f9e
@LorenzoBettini
Merge pull request eclipse#52 from eclipse/lb_2-36
c75b2da 
preparation for 2.36.
@crapo
moving image to images folder
2101940
@crapo
Merge branch 'eclipse:main' into patch-1
5949b18
@miklossy
Copy link
Contributor

miklossy commented Jul 8, 2024

@crapo maybe it's better if you put the PNG image in the images directory like we did for other images

Since the PNG image has been put into the images directory (see 2101940), I think we could merge this PR.

@LorenzoBettini @cdietrich what do you think?

@cdietrich
Copy link
Member

i wonder if we can cleanup the commit history

@crapo
Copy link
Contributor Author

crapo commented Jul 8, 2024

If that is directed at me, I'm not sure exactly what that means or how to do it.

@cdietrich
Copy link
Member

yes i wonder if you can rebase and squash all your changes into one commit

@LorenzoBettini
Copy link
Contributor

@cdietrich we can do that ourselves when merging (Squash and merge)

@cdietrich
Copy link
Member

@LorenzoBettini if you could do that i am fine with it

@LorenzoBettini LorenzoBettini merged commit ea08d69 into eclipse:published Jul 8, 2024
1 check passed
@miklossy miklossy mentioned this pull request Jul 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdietrich cdietrich cdietrich left review comments

@miklossy miklossy miklossy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crapo @cdietrich @LorenzoBettini @miklossy @szarnekow