Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mvn] Use ${project.version} instead of hard-coded references #1241

Open
kthoms opened this issue Jul 12, 2018 · 8 comments
Open

[mvn] Use ${project.version} instead of hard-coded references #1241

kthoms opened this issue Jul 12, 2018 · 8 comments
Labels

Comments

@kthoms
Copy link

kthoms commented Jul 12, 2018

Some POMs contain redundant information on the used Xtext version, e.g. xtext-core/releng/pom.xml

		<dependency>
			<groupId>org.eclipse.xtext</groupId>
			<artifactId>org.eclipse.xtext</artifactId>
			<version>2.15.0-SNAPSHOT</version>
		</dependency>
		<dependency>
			<groupId>org.eclipse.xtext</groupId>
			<artifactId>org.eclipse.xtext</artifactId>
			<version>2.15.0-SNAPSHOT</version>
			<classifier>sources</classifier>
		</dependency>

The version 2.15.0-SNAPSHOT can be replaced by ${project.version}.

This makes the changeset smaller when changing versions.

@kthoms kthoms added the releng label Jul 12, 2018
kthoms pushed a commit to eclipse/xtext-lib that referenced this issue Jul 12, 2018
…coded version

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
kthoms pushed a commit to eclipse/xtext-core that referenced this issue Jul 12, 2018
…coded version

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
kthoms pushed a commit to eclipse/xtext-extras that referenced this issue Jul 12, 2018
…coded version

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
@cdietrich
Copy link
Member

Surr the publishing Project can handle that ?

@kthoms
Copy link
Author

kthoms commented Jul 13, 2018

What's so special about the publishing project? You mean the CI job?
That's quite a usual style in MVN. It is a simple variable substitution.

@cdietrich
Copy link
Member

i mean that typefox thingy that pushes the stuff to soanytype and maven central.
e.g. in out maven plugins we need to uplicate stuff from parent poms.

@LorenzoBettini
Copy link
Contributor

When this #2231 is implemented there'll be no need to use versions at all (and I hope that it won't break publishing ;)

@kthoms
Copy link
Author

kthoms commented Jul 13, 2018

At least you would have to specify the BOM's version, which again is the project version. It is just less dependencies listed.

@LorenzoBettini
Copy link
Contributor

yes!

@cdietrich
Copy link
Member

p2 gen is removed now. to be tested: can publish plugin handle it without explicit version

@cdietrich
Copy link
Member

see also #2135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants