Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make old generator more optional #2042

Closed
cdietrich opened this issue Feb 25, 2022 · 8 comments
Closed

Make old generator more optional #2042

cdietrich opened this issue Feb 25, 2022 · 8 comments
Assignees
@cdietrich
Labels
releng
Milestone
Release_2.27

Comments

@cdietrich
Copy link
Member

Make old generator more optional
@cdietrich cdietrich added this to the Release_2.27 milestone Feb 25, 2022
cdietrich added a commit to eclipse/xtext-umbrella that referenced this issue Feb 25, 2022
@cdietrich
[eclipse/xtext#2042] package old generator separately
0a5eed0 
Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
cdietrich added a commit to eclipse/xtext-umbrella that referenced this issue Feb 25, 2022
@cdietrich
[eclipse/xtext#2042] package old generator separately
8f174c8 
Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
cdietrich added a commit to eclipse/xtext-umbrella that referenced this issue Feb 25, 2022
@cdietrich
[eclipse/xtext#2042] package old generator separately
7fa455d 
Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
@cdietrich
Copy link
Member Author

https://github.com/eclipse/xtext-umbrella/compare/cd_moreOldGeneratorExperiments

@cdietrich
Copy link
Member Author

@kthoms @szarnekow what do you think?

cdietrich added a commit to eclipse/xtext-umbrella that referenced this issue Feb 25, 2022
@cdietrich
[eclipse/xtext#2042] package old generator separately
9ab9da3 
Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
@cdietrich cdietrich mentioned this issue Feb 25, 2022
Closed
@kthoms
Copy link

kthoms commented Feb 27, 2022

I'm understanding that the Xpand dependencies are not part of the Xtext Runtime feature, but from a new feature. This is optional, and Xtext itself is not directly dependent on it. So it looks like a good way forward.

@szarnekow
Copy link
Contributor

Good idea! I'm in favor of this proposal.

cdietrich added a commit to eclipse/xtext-umbrella that referenced this issue Feb 28, 2022
@cdietrich
[eclipse/xtext#2042] package old generator separately
82b6076 
Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
@cdietrich cdietrich mentioned this issue Feb 28, 2022
Closed
@cdietrich cdietrich self-assigned this Feb 28, 2022
cdietrich added a commit to eclipse/xtext-umbrella that referenced this issue Mar 3, 2022
@cdietrich
[eclipse/xtext#2042] package old generator separately
6d36cbc 
Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
@cdietrich cdietrich mentioned this issue Mar 4, 2022
Merged
cdietrich added a commit to eclipse/xtext-umbrella that referenced this issue Mar 4, 2022
@cdietrich
[eclipse/xtext#2042] package old generator separately
908c59e 
Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
cdietrich added a commit to eclipse/xtext-umbrella that referenced this issue Mar 4, 2022
@cdietrich
[eclipse/xtext#2042] package old generator separately
82a71b1 
Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
cdietrich added a commit to eclipse/xtext-umbrella that referenced this issue Mar 4, 2022
@cdietrich
Merge pull request #303 from eclipse/cd_moreOldGeneratorExperiments_v…
295bd76 
…ariant_b

[eclipse/xtext#2042] package old generator separately
@cdietrich
Copy link
Member Author

done

@ewillink
Copy link

ewillink commented Mar 6, 2022

https://bugs.eclipse.org/bugs/show_bug.cgi?id=579108 identifies that org.eclipse.xtext.generator is no longer fetchable although it is still packaged in the repo.

Workaround - augment all the *.target files from

to

Since Xtext has not undergone a major version change, surely the old generator must remain available?

Surely you need to offer e.g. org.eclipse.xtext.newsdk.feature.group to avoid breaking your previous contracts?

@cdietrich
Copy link
Member Author

It is available. Simply use new feature in target

@cdietrich
Copy link
Member Author

Alternative talk to the foundation about the reload4j crap they are doing and will even do worse

cdietrich added a commit that referenced this issue Mar 7, 2022
@cdietrich
[#2042] add hint about new xtext.generator feature to release notes
1cdb4a5 
Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
@miklossy miklossy mentioned this issue Mar 9, 2022
Closed
szarnekow pushed a commit to eclipse/xtext-website that referenced this issue Mar 18, 2023
@cdietrich
[eclipse/xtext#2042] add hint about new xtext.generator feature to re…
bc391f8 
…lease notes

Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
szarnekow pushed a commit to eclipse/xtext-website that referenced this issue Mar 18, 2023
@cdietrich
[eclipse/xtext#2042] add hint about new xtext.generator feature to re…
3e6b765 
…lease notes

Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdietrich cdietrich

Labels
releng
Projects
None yet
Milestone
Release_2.27
Development

No branches or pull requests
4 participants
@cdietrich @kthoms @szarnekow @ewillink