Timeout on Tycho 4/5 builds

[cdietrich]

Tycho 4/5 builds regularly get killed due to hanging tests it seems
needs to be investigated

cc @LorenzoBettini @szarnekow

https://ci.eclipse.org/xtext/job/xtext/job/cd_tycho40/
https://ci.eclipse.org/xtext/job/xtext/job/cd_tycho50/

[cdietrich]

SeveralEditorsQueuedBuildTest seems to be one culprit, SaveWithReconciliationQueuedBuildDataTest another one

[LorenzoBettini]

Only in Jenkins? Or also on GitHub Actions?

[cdietrich]

does this run on actions daily at all. not to MY knowledge

[LorenzoBettini]

I meant the workflows that ran the first time you pushed those branches.

[cdietrich]

this branches are month old and updated quite seldom only.
but i usually dont check github action results for them

[cdietrich]

wonder if there is an option to get a jstack / thread dump on timeout

[cdietrich]

found https://lists.apache.org/thread/mc276n4z31kqomk2zdfm7ybw21k7bz4v

[cdietrich]

we might also have to set a test timeout.
right now its the jenkins job that times out

[LorenzoBettini]

I don't know if that's the case, but the last time I saw a stuck job on Xtext GitHub Actions, which I had to cancel, was due to a small bug I introduced in my fork that caused Xtend renaming, throwing an exception. Of course, I could reproduce the bug locally: everything was stuck due to the Eclipse dialog showing the uncaught exception. With that dialog on the way, the tests did not proceed at all...

[cdietrich]

hang can be reproduced locally
@szarnekow any idea
a2.log
what are we waiting for there

[cdietrich]

maybe
org.eclipse.xtend.ide.tests.builder.JavaEditorExtension.waitForElementChangedEvent(int, ()=>void)
should get a timeout.
but that would lead to flaky tests i guess

[szarnekow]

I'm pretty sure there should be an event since we change the content of the editor.
Very surprising.

[LorenzoBettini]

If I understand correctly this problem shows up only since Tycho 4, right?
And it is a race condition?
I wonder if in Tycho they introduce some default configuration for parallel tests that break these tests.

[cdietrich]

saw it run as plugin test.

[LorenzoBettini]

saw it run as plugin test.

What do you mean?
It runs fine when executed from Eclipse?

[cdietrich]

No it hang on the 10th attempt or so

[LorenzoBettini]

Maybe trying with org.eclipse.xtend.ide.tests.builder.JavaEditorExtension.VERBOSE set to true and see what happens? I cannot reproduce it locally.

By the way,

	def waitForElementChangedEvent(int eventMask, =>void producer) {
		if (VERBOSE) {
			println('''start waiting for an element changed event: «eventMask»''')
		}
		val changed = new AtomicBoolean(false)
		JavaCore.addElementChangedListener(
			[
				JavaCore.removeElementChangedListener(self)
				if (!changed.get) {
					changed.set(true)
					if (VERBOSE) {
						println(it)
					}
				}
			], eventMask)
		producer.apply
		while (!changed.get) {
			if (Display.getCurrent() !== null) {
				while (Display.getDefault().readAndDispatch()) {
					// process queued ui events
				}
			}
		}
		if (VERBOSE) {
			println('''end waiting for an element changed event: «eventMask»''')
		}
	}

maybe it should never be the case but if Display.getCurrent() is null we never exit that while loop.

[cdietrich]

log says start waiting for an element changed event: 1
with verbose.
15th attempt this time
which tp do you use?

[cdietrich]

[cdietrich]

maybe in recent jdt something about reconciliation has changed that it never happens

[LorenzoBettini]

which tp do you use?

The latest. Reloaded this morning.

[cdietrich]

am also using latest

[LorenzoBettini]

What does the screenshot want to show? Is the program stuck there?

[cdietrich]

yes. so the event is never produced

[LorenzoBettini]

I cannot reproduce it on macOS m1 nor on a slower laptop with Linux...

On the screenshot, the console shows that the event has been caught and printed on the screen.

Could you please try this?

		while (!changed.get && Display.getDefault().readAndDispatch()) {
			if (VERBOSE) {
				println("readAndDispatch")
			}
		}

[cdietrich]

leads to test errors with

/*******************************************************************************
 * Copyright (c) 2024 itemis AG (http://www.itemis.eu) and others.
 * This program and the accompanying materials are made available under the
 * terms of the Eclipse Public License 2.0 which is available at
 * http://www.eclipse.org/legal/epl-2.0.
 * 
 * SPDX-License-Identifier: EPL-2.0
 *******************************************************************************/
package org.eclipse.xtend.ide.tests.builder;

import org.junit.runner.RunWith;
import org.junit.runners.Suite;
import org.junit.runners.Suite.SuiteClasses;

/**
 * @author dietrich - Initial contribution and API
 */
@RunWith(Suite.class)
@SuiteClasses({
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
	SeveralEditorsQueuedBuildTest.class,	
})
public class DullySuite {

}

[LorenzoBettini]

Yes, on this line (assertThereAreNotDeltas)

		barEditor.save
		queuedBuildDataContribution.unconfirmedDeltas.assertThereAreDeltas("mypackage.Bar")
		queuedBuildData.andRemovePendingDeltas.assertThereAreNotDeltas

[LorenzoBettini]

...but only sometimes on my computer (though I'm not using your suite)