Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2176] use guice namespace annotations to prepare switch from javax.inject to jakarta.inject in guice #2654

Merged
merged 1 commit into from
May 5, 2023

Conversation

cdietrich
Copy link
Member

[#2176] use guice namespace annotations to prepare switch from javax.inject to jakarta.inject in guice

…inject to jakarta.inject in guice

Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
@cdietrich cdietrich added this to the Release_2.31 milestone May 5, 2023
@cdietrich cdietrich requested a review from szarnekow May 5, 2023 11:06
Copy link
Contributor

@szarnekow szarnekow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that we had so many usages of javax.inject.

Thank you for cleaning this up.

@cdietrich cdietrich merged commit 48b07b5 into main May 5, 2023
6 of 7 checks passed
@cdietrich cdietrich deleted the cd_javaxinject branch May 5, 2023 15:33
@LorenzoBettini
Copy link
Contributor

Maybe unrelated, but GitHub Actions build on macOS started to fail again because of mwe2... I thought I had solved that in the past but it's showing up again...

@cdietrich
Copy link
Member Author

yes i saw this multiple times the last days. it says connection reset.
maybe something wrong with maven central connection on github action side

@LorenzoBettini
Copy link
Contributor

I still think it's the Maven version: in GitHub Actions macOS it's 3.9.1
and I still believe the versions [number] in mwe2 poms are wrong ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants