Update to Guice 7 and Guava 32 #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO create mwe milestone and use that |
cdietrich
commented
Jun 19, 2023
xtext-r202212.target
Outdated
| <unit id="org.objectweb.asm" version="9.5.0"/> | ||
| <unit id="io.github.classgraph" version="4.8.149.v20220915-0556"/> | ||
| <unit id="org.slf4j.binding.simple" version="0.0.0"/> | ||
| <unit id="org.junit" version="4.13.2.v20211018-1956"/> | ||
| <unit id="junit-jupiter-api" version="0.0.0"/> |
cdietrich
force-pushed
the
cd_testg32guice7
branch
2 times, most recently
from
e84ff29
to
f20fb85
Compare
cdietrich
commented
Jun 19, 2023
| @@ -32,16 +32,16 @@ protected void bindToInstance(LinkedBindingBuilder<Object> bind, Object instance | |||
| @SuppressWarnings("unchecked") | |||
| @Override | |||
| protected void bindToClass(LinkedBindingBuilder<Object> bind, Class<?> value) { | |||
There was a problem hiding this comment.
ok this way? still needed?
szarnekow
reviewed
Jun 19, 2023
| @@ -59,6 +63,11 @@ | |||
|
|
|||
|
|
|||
| <target name="compiler.init" depends="clean"> | |||
| <!-- | |||
There was a problem hiding this comment.
Do you want to keep this for future use?
There was a problem hiding this comment.
it at least helped me debugging
szarnekow
reviewed
Jun 19, 2023
...tests/tests/org/eclipse/xtext/common/types/access/xtext/ui/JdtBasedConstructorScopeTest.java
Show resolved
Hide resolved
szarnekow
reviewed
Jun 19, 2023
| org.eclipse.xtext.testing | ||
| Import-Package: org.apache.log4j;version="1.2.24", | ||
| org.eclipse.xtext.testing, | ||
| com.google.inject;bundle-version="7.0.0";visibility:=reexport, |
There was a problem hiding this comment.
These are all re-exported from xtext.util.
Why are these changes necessary?
There was a problem hiding this comment.
dont know. needs to be tested
There was a problem hiding this comment.
IIRC, this project was created with copy and paste and its dependencies were never updated.
cdietrich
force-pushed
the
cd_testg32guice7
branch
2 times, most recently
from
b8571b9
to
c833098
Compare
|
running workflows from eclipse leads to => also reexport this one? |
|
but where? |
|
doing the same reexport in xtext.util seems to work |
cdietrich
force-pushed
the
cd_testg32guice7
branch
from
7864d68
to
2754642
Compare
cdietrich
commented
Jun 21, 2023
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <unit id="org.eclipse.xtext.sdk.feature.group" version="0.0.0"/> | ||
| <repository location="https://download.eclipse.org/modeling/tmf/xtext/updates/nightly"/> | ||
| <repository location="https://ci.eclipse.org/xtext/job/xtext/job/cd_testg32guice7/lastSuccessfulBuild/artifact/build/p2-repository/"/> |
There was a problem hiding this comment.
TODO revert before merge
|
@szarnekow how to continue here? |
szarnekow
approved these changes
Jun 25, 2023
Let's continue the merge + mwe2 release dance |
cdietrich
force-pushed
the
cd_testg32guice7
branch
2 times, most recently
from
90db797
to
639b980
Compare
Signed-off-by: Sebastian Zarnekow <sebastian.zarnekow@gmail.com>
reexport failureaccess Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de> package more stuff
cdietrich
force-pushed
the
cd_testg32guice7
branch
from
639b980
to
4459d5f
Compare
|
Note that guava 32.1.0.jre is now available in the usual places including of course here: https://repo1.maven.org/maven2/com/google/guava/guava/32.1.0-jre/ |
|
Does this mean you removed the old ? |
|
Yes. |
|
created #2726 |
merks
referenced
this pull request
in eclipse-oomph/oomph.incubator
Jul 1, 2023
com.google.guava:guava:32.0.1-jre
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.